Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: safe precache #15

Open
voed opened this issue Jun 17, 2018 · 4 comments
Open

Suggestion: safe precache #15

voed opened this issue Jun 17, 2018 · 4 comments

Comments

@voed
Copy link
Contributor

voed commented Jun 17, 2018

Description

Check if file exists before precache, so server wont crash if user forgot to put resource in folder. But we need to stop plugin if resource not precached(SetFailState)

Other Comments

@WPMGPRoSToTeMa
Copy link

What is bad with crash?
I have one idea - not all missed resources are displayed. But this solution also don't solve it.

@voed
Copy link
Contributor Author

voed commented Jun 20, 2018

I think its wrong if plugin crashes server. Typical example: you are testing plugin locally, works fine, then you uploading it to dedicated server and server crashed. You need to enable condebug and check what happened, then you like "oh crap, i forgot to upload a model!"
Example 2: you uploaded plugin, plugin crashed and said "you forgot to upload a model!"

@WPMGPRoSToTeMa
Copy link

You need to enable condebug

So, we can solve this problem by automatically forced crash log, isn't it?

you uploaded plugin, plugin crashed

And ... you didn't see that, because you just installed the plugin and forgot about it. This also is a problem, plugin crashes should be more noticeable, server crash is very noticeable, error messages in console aren't noticeable. Yeah server crash isn't the best way, but I don't know about the other noticeable ways.

@voed
Copy link
Contributor Author

voed commented Jun 21, 2018

plugin crashes should be more noticeable

Notification to front menu that some plugin is crashed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants