New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some of the js-mode snippets depend on js2-mode #329

Open

qqlearn123 opened this issue Jul 20, 2019 · 0 comments

qqlearn123 commented Jul 20, 2019 •

edited

Loading

I found that some snippets inside js-mode have dependency on functions of js2-mode, which causes errors reported if I do not have js2-mode installed.

For example, the 'param-comment' snippet is defined as:

# -*- mode: snippet -*-
# name: param-comment
# key: *@p
#condition: (= (js2-node-type (js2-node-at-point)) js2-COMMENT)
# --
* @param {${type}} ${comment}.

So, is it more appropriate to put those snippets which depend on js2-mode into js2-mode snippets?

Thanks and look forward to hearing from you.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment