Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Typesync Monorepo support #193

Open
lishaduck opened this issue Aug 8, 2024 · 2 comments · May be fixed by #312 or #295
Open

Use Typesync Monorepo support #193

lishaduck opened this issue Aug 8, 2024 · 2 comments · May be fixed by #312 or #295
Assignees
@AndreaPontrandolfo
Labels
accepted The issue is accepted and a PR can be proposed. refactor

Comments

@lishaduck
Copy link
Contributor

lishaduck commented Aug 8, 2024 •
edited
Loading

sheriff/package.json

Line 16 in 1191582

"typesync": "turbo run typesync",

8a01931 updated Typesync to v0.13, but kept the individual scripts. It'd be more efficient to just run it from the root. 🤞 it ought to pick up the packages and do it all concurrently, but without the startup cost of npx+node. And it'd work without needing to be added per-package.
@AndreaPontrandolfo
Copy link
Owner

Does it means we can also have a single .typesyncrc.json at root?

Can you PR this?

@lishaduck
Copy link
Contributor Author

Does it means we can also have a single .typesyncrc.json at root?

Yes.

Can you PR this?

I'll try to get to it sometime.

@AndreaPontrandolfo AndreaPontrandolfo added accepted The issue is accepted and a PR can be proposed. refactor labels Aug 17, 2024
@AndreaPontrandolfo AndreaPontrandolfo self-assigned this Nov 1, 2024
AndreaPontrandolfo added a commit that referenced this issue Nov 1, 2024
@AndreaPontrandolfo
chore: WIP, use Typesync Monorepo support
dab7e87 
Fixes #193
@AndreaPontrandolfo AndreaPontrandolfo linked a pull request Nov 1, 2024 that will close this issue
Draft
@lishaduck lishaduck moved this from Todo to In Review in @lishaduck's todo list Nov 3, 2024
@lishaduck lishaduck moved this from In Review to Blocked in @lishaduck's todo list Nov 3, 2024
@lishaduck lishaduck moved this from Blocked to In Progress in @lishaduck's todo list Nov 13, 2024
@lishaduck lishaduck moved this from In Progress to Blocked in @lishaduck's todo list Nov 13, 2024
lishaduck added a commit to lishaduck/sheriff that referenced this issue Dec 3, 2024
@lishaduck
chore(deps): bump typesync, use monorepo support
420add1 
Closes: AndreaPontrandolfo#193.
@lishaduck lishaduck linked a pull request Dec 3, 2024 that will close this issue
Open
lishaduck added a commit to lishaduck/sheriff that referenced this issue Dec 3, 2024
@lishaduck
chore(deps): bump typesync, use monorepo support
44b6584 
Closes: AndreaPontrandolfo#193.
@lishaduck lishaduck mentioned this issue Dec 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreaPontrandolfo AndreaPontrandolfo

Labels
accepted The issue is accepted and a PR can be proposed. refactor
Projects
None yet
Milestone
No milestone
2 participants
@AndreaPontrandolfo @lishaduck