-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DISMISS doesn't work #48
Comments
Ana06
added a commit
to Ana06/automatic-pull-request-review
that referenced
this issue
May 27, 2021
`addPullRequestReview` doesn't work with `DISMISS`. Use `dismisspullrequestreview` instead in this case. Closes AndrewMusgrave#48
Ana06
added a commit
to Ana06/automatic-pull-request-review
that referenced
this issue
May 27, 2021
`Ana06/[email protected]` is a fork of https://github.com/AndrewMusgrave/automatic-pull-request-review which [fixes DISMISS](AndrewMusgrave#48) and provides an `allow_duplicate` option which allows to [only approve once](AndrewMusgrave#39).
I have released Ana06/[email protected] which fixes this and includes #47: Ana06/automatic-pull-request-review@0.0.5...v0.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems that the
addPullRequestReview
mutation doesn't supportDISMISS
. I think this is a GitHub bug and not a problem in the action itself. But as a result the action is broken. You can check this with the following queries in https://docs.github.com/en/graphql/overview/explorer:I reported it to GitHub 9 days ago. GitHub support has told me to use the
dismisspullrequestreview
mutation. They are still looking into it, so it might be that they fixaddPullRequestReview
to supportDISMISS
. Otherwise we could update the code to usedismisspullrequestreview
, as it seems to be working properly. I can send a PR after #47 (to avoid merge conflicts).The text was updated successfully, but these errors were encountered: