Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Replace Skypack with esm.sh as default source #95

Closed
nojaf opened this issue Mar 21, 2023 · 5 comments
Closed

Replace Skypack with esm.sh as default source #95

nojaf opened this issue Mar 21, 2023 · 5 comments
Labels
1.x Issues made for v1 preview versions enhancement New feature or request feedback in-dev The item has been worked and can be found in the dev branch

Comments

@nojaf
Copy link
Contributor

nojaf commented Mar 21, 2023

Hello,

I'm circling back to my Perla project to try and update everything to Fable 4.
I had to install some new packages and long story short things aren't going well with Skypack: skypackjs/skypack-cdn#343.

I used https://esm.sh/ as a workaround. (Installed things manually)
And I think it could be a great replacement for the default source when adding a package.

Thoughts?

@nojaf nojaf added the feedback label Mar 21, 2023
@AngelMunoz
Copy link
Owner

Hey there, nice to have you back

In the latest previews I actually did change skypack for jspm as the default CDN, for the moment since I'm relying in the jspm generator API I can only support what they support (jspm, skypack, unpkg, jsdlivr) I'll investigate a little bit around esm.sh and see if they have an API I can tap into, so we can consider adding it to the list of out of the box supported CDNs.

However, as you can see you can manually update those in the import map and things should just work it is one of the advantages import maps have!

@AngelMunoz
Copy link
Owner

Just in case you're wondering about the jspm generator api
https://jspm.org/docs/api

The Apis we're currently using are in the Generator section

@AngelMunoz
Copy link
Owner

I just gave another look to their generator CLI, it looks like esm.sh support has been added

https://github.com/jspm/generator/tree/main#providers

So I will look into incorporate this into perla as well

@nojaf
Copy link
Contributor Author

nojaf commented Mar 24, 2023

Oh that is great! Thanks a bunch.
Because, as far as I understood it, similar to skypack, esm.sh will actually expose es6 modules.
Even if the npm package uses something else, which is really what we are after.

@AngelMunoz AngelMunoz added the 1.x Issues made for v1 preview versions label Apr 12, 2023
@AngelMunoz
Copy link
Owner

Using esm.sh as source has been enabled for beta 16

@AngelMunoz AngelMunoz mentioned this issue Apr 13, 2023
@AngelMunoz AngelMunoz moved this to ✅ Done in Perla Tracker Apr 13, 2023
@AngelMunoz AngelMunoz added enhancement New feature or request in-dev The item has been worked and can be found in the dev branch labels Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.x Issues made for v1 preview versions enhancement New feature or request feedback in-dev The item has been worked and can be found in the dev branch
Projects
Status: Done
Development

No branches or pull requests

2 participants