Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop relying on the filesystem in the core library #40

Closed
Angelmmiguel opened this issue Feb 14, 2022 · 0 comments · Fixed by #43
Closed

Stop relying on the filesystem in the core library #40

Angelmmiguel opened this issue Feb 14, 2022 · 0 comments · Fixed by #43
Assignees
Milestone

Comments

@Angelmmiguel
Copy link
Owner

Currently, the core library can load a SVG file directly from the filesystem. The main purpose of the core library is to read a SVG content and extract information from it. The load of the SVG content from the filesystem is not directly related to the core feature and it can be done from the CLI side.

Using fs in the core library is preventing other interesting use cases for SVGI as the core library can be used in web apps too. An example of this limitation is #19.

After removing this dependency, the core library will be valid for the browser environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant