Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added changes to login signup page #1162

Closed

Conversation

DiwareNamrata23
Copy link
Contributor

@DiwareNamrata23 DiwareNamrata23 commented Aug 8, 2024

Description

Related Issues

Type of PR

Screenshots / videos (if applicable)

Screenshot 2024-08-08 at 10 54 22 PM Screenshot 2024-08-08 at 10 54 30 PM

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2024 5:10pm

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit f681db8
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66b79f044e027b0008a5077a
😎 Deploy Preview https://deploy-preview-1162--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @DiwareNamrata23! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@DiwareNamrata23
Copy link
Contributor Author

@varshith257 removed conflicts

index.html Outdated Show resolved Hide resolved
@varshith257
Copy link
Collaborator

Also align footer with the home page one

@DiwareNamrata23
Copy link
Contributor Author

Plz merge my pr

@DiwareNamrata23
Copy link
Contributor Author

@varshith257 now there are no conflicts plz merge my pr

@varshith257
Copy link
Collaborator

@DiwareNamrata23 In deploy the page is misaligned. Have a look

@DiwareNamrata23
Copy link
Contributor Author

Hi @varshith257 can you plz elaborate where is the issue

@varshith257
Copy link
Collaborator

In netifly deployment

@varshith257
Copy link
Collaborator

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 30c4070
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66b591c36a3c150008c3fa3d
😎 Deploy Preview https://deploy-preview-1162--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Here

@DiwareNamrata23
Copy link
Contributor Author

@varshith257 can we have a quick google meet?

@varshith257
Copy link
Collaborator

@varshith257 can we have a quick google meet?

Sure

@DiwareNamrata23
Copy link
Contributor Author

DiwareNamrata23 commented Aug 9, 2024

To join the video meeting, click this link: https://meet.google.com/byb-bhic-eia
Otherwise, to join by phone, dial +1 336-365-5804 and enter this PIN: 209 873 779#
Can you please join

log/script.js Outdated Show resolved Hide resolved
@DiwareNamrata23
Copy link
Contributor Author

@varshith257 is it working good now ?

@varshith257
Copy link
Collaborator

@Anjaliavv51 Once verify it

Copy link
Contributor

@Anjaliavv51 Anjaliavv51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DiwareNamrata23 please check the deployment in netlify , their is gap between the sub footer section in footer tag and also the login container is overflowed.

Screenshot_20240810_224310_Chrome

@Anjaliavv51
Copy link
Contributor

@varshith257 my suggestion is that their is no need of header and footer to the login page.

The current login page looks great , I this issue and PR need to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants