Error 404 - Error while retrieving tasks

[makdeuneuv]

Description

When we go to the task page, we get a 404 error - StudyNotFoundError.
This happened when a user deleted a variant on which a simulation was running. It's impossible to cancel this task.

Steps to Reproduce

1. Create a managed study
2. create a variant and made some modifications on this variant
3. launch a simulation on this variant
4. wait a moment, when the simulation is started on CALIN, go delete the variant
5. come back on task page and now you get the 404 error
6. In some case, the task will be done a few moment later (in staging) or it will never ended (in production)

Screenshots

Possible Solution

No control is made when deleting a variant or a study.
It would be necessary to prevent the deletion of a study (variant or not) when this one has one or more simulations in progress.
Another solution could be, when a user makes a call to the deletion function of a study (web app or API), this same function will first stop the simulations in progress before being deleted.

Environment

• Production
• Staging

[MartinBelthle]

What could be done :

1. Before deleting a study, kill every job associated to it because they are now useless and prevent other studies to be launched. This requires a bit of development in the back-office but not in the front.
2. When clicking on the "Tasks" tab, filter task with the parameter filter_orphans=True. Currently, this parameter value is False and it is a nonsense to me. Changing it to True will prevent tasks with deleted studies to appear in the front-office. The parameter already exists and the only change to do will be in the front. This would also solve this issue Presence of tasks from a deleted study in the task view. #1470

Does this solution suits you @deneuv ?

[MartinBelthle]

Also, from what i have tested, this doesn't only apply to variant but to raw studies as well so i remove the variant label.

[laurent-laporte-pro]

1. Before deleting a study, kill every job associated to it because they are now useless and prevent other studies to be launched. This requires a bit of development in the back-office but not in the front.

Not sure. There can also be an impact on the front-end side, as some objects are saved in the web browser's Data Store.

[MartinBelthle]

I'm not sure to understand how launcher jobs are saved in the web browser's Data Store. I thought we could just get every job associated to the study the same way the API does and kill each one.

[makdeuneuv]

@MartinBelthle I think the solution 2 is better.