Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users shouldn't be able to scan a managed workspace in the front-end #1667

Open
MartinBelthle opened this issue Jul 25, 2023 · 0 comments · May be fixed by #1668
Open

Users shouldn't be able to scan a managed workspace in the front-end #1667

MartinBelthle opened this issue Jul 25, 2023 · 0 comments · May be fixed by #1668
Labels
enhancement New feature or request front-end

Comments

@MartinBelthle
Copy link
Contributor

Description

Scanning a workspace allows AntaresWeb to retrieve studies that were not already in its database
So it does not make sense to scan any managed folder.

However, it is possible using the front-end (little "target" icon at the very right of the screenshot below):
scanner_default

It is also possible to do so using the API.
If this happens, the back-end currently raises an Exception and the task fails.

2 things need to be implemented:

  • The back office should not raise an Exception but simply log the fact that this doesn't make sense
  • The front office should not display the little "target" icon when the folder to scan is a child of "default" workspace.

The back-end part is quite easy and already implemented in the linked PR, so it solves the API issue.

The front-office however could be more tricky as every information is gathered with the endpoint GET /studies when the user clicks on the Studies page and no other API call is raised when the user clicks on any folder.

@MartinBelthle MartinBelthle added the enhancement New feature or request label Jul 25, 2023
@MartinBelthle MartinBelthle changed the title Users shouldn't be able to scan a managed workspace Users shouldn't be able to scan a managed workspace in the front-end Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request front-end
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant