Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: HotStuff finality should drive LIB in controller #1522

Closed
Tracked by #1508
arhag opened this issue Aug 17, 2023 · 2 comments
Closed
Tracked by #1508

IF: HotStuff finality should drive LIB in controller #1522

arhag opened this issue Aug 17, 2023 · 2 comments
Assignees
@greg7mdp @heifner
Labels
👍 lgtm
Milestone
Leap v6.0.0-rc1

Comments

@arhag
Copy link
Member

arhag commented Aug 17, 2023 •
edited
Loading

Depends on #1523.

For this issue, we are still not switching existing tests over to use IF.

However, a new unit test is needed that switches to IF to test whether LIB is being driven correctly by HotStuff.
@arhag arhag mentioned this issue Aug 17, 2023
Closed
@arhag arhag added 👍 lgtm and removed triage labels Aug 17, 2023
@arhag arhag added this to the Leap v5.0.0-rc1 milestone Aug 17, 2023
@heifner heifner mentioned this issue Aug 22, 2023
Closed
This was referenced Aug 24, 2023
Closed
Closed
@heifner heifner mentioned this issue Aug 31, 2023
Closed
@greg7mdp greg7mdp self-assigned this Sep 8, 2023
@greg7mdp
Copy link
Contributor

greg7mdp commented Sep 8, 2023

Assigning myself to this issue because it is related to #1586 I am working on.

@greg7mdp greg7mdp linked a pull request Sep 8, 2023 that will close this issue
IF: Add block extension which contains latest HotStuff commitment known to proposer #1607
Closed
@arhag arhag removed this from the Leap v5.0.0-rc1 milestone Sep 19, 2023
@bhazzard bhazzard added this to the Leap v6.0.0-rc1 milestone Nov 1, 2023
@arhag arhag removed a link to a pull request Nov 28, 2023
IF: Add block extension which contains latest HotStuff commitment known to proposer #1607
Closed
@heifner heifner mentioned this issue Nov 28, 2023
Merged
@heifner
Copy link
Member

heifner commented Nov 28, 2023

Resolved by #1640

@heifner heifner closed this as completed Nov 28, 2023
@heifner heifner self-assigned this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg7mdp greg7mdp

@heifner heifner

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

No branches or pull requests
5 participants
@bhazzard @greg7mdp @heifner @arhag @enf-ci-bot