Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Implement string serialization for bls_* types #1532

Closed
Tracked by #1508
heifner opened this issue Aug 18, 2023 · 3 comments · Fixed by #1538
Closed
Tracked by #1508

IF: Implement string serialization for bls_* types #1532

heifner opened this issue Aug 18, 2023 · 3 comments · Fixed by #1538
Assignees
@systemzax
Labels
👍 lgtm

Comments

@heifner
Copy link
Member

heifner commented Aug 18, 2023 •
edited
Loading

Need base58 encode/decode to/from string for: bls_public_key, bls_private_key, bls_signature.
@heifner heifner mentioned this issue Aug 18, 2023
Closed
@heifner heifner added 👍 lgtm and removed triage labels Aug 18, 2023
@arhag
Copy link
Member

arhag commented Aug 18, 2023

Make sure checksum is included as part of the encoding. Also this relates to AntelopeIO/cdt#210. Both CDT and Leap will need the encoding/decoding implementations.

@arhag arhag added this to the Leap v5.0.0-rc1 milestone Aug 18, 2023
@heifner heifner mentioned this issue Aug 21, 2023
Closed
@arhag arhag linked a pull request Aug 22, 2023 that will close this issue
IF: Clean up of bls_private_key, bls_public_key and bls_signature, … #1538
Merged
@arhag
Copy link
Member

arhag commented Aug 24, 2023

Implementation for encoding/decoding BLS public keys can be shared with AntelopeIO/cdt#215.

This was referenced Aug 24, 2023
Closed
Closed
Closed
@heifner
Copy link
Member Author

heifner commented Aug 29, 2023

Completed by #1538

@heifner heifner closed this as completed Aug 29, 2023
@arhag arhag mentioned this issue Aug 31, 2023
Closed
@arhag arhag removed this from the Leap v5.0.0-rc1 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@systemzax systemzax

Labels
👍 lgtm
Projects
Team Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IF: Clean up of bls_private_key, bls_public_key and bls_signature, … AntelopeIO/leap
4 participants
@heifner @systemzax @arhag @enf-ci-bot