Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Remove recursive implementation of commit in qc_chain #1553

Closed
Tracked by #1508
heifner opened this issue Aug 24, 2023 · 0 comments · Fixed by #1565
Closed
Tracked by #1508

IF: Remove recursive implementation of commit in qc_chain #1553

heifner opened this issue Aug 24, 2023 · 0 comments · Fixed by #1565
Assignees
@greg7mdp @heifner
Labels
👍 lgtm

Comments

@heifner
Copy link
Member

heifner commented Aug 24, 2023 •
edited
Loading

See
https://github.com/AntelopeIO/leap/pull/1536/files#r1304495161

Recursive algorithms can be problematic for limiting execution time and for stack usage. Change to a loop instead.
Although, unlikely that we can interrupt this processing. Will just have to pay the execution time. Stack usage however is an issue.
@heifner heifner mentioned this issue Aug 24, 2023
Closed
@heifner heifner mentioned this issue Aug 24, 2023
Closed
@arhag arhag added 👍 lgtm and removed triage labels Aug 24, 2023
@heifner heifner self-assigned this Aug 26, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Aug 26, 2023
heifner added a commit that referenced this issue Aug 26, 2023
@heifner
GH-1553 Rewrite to rm recursive implementation
22c0a44
@heifner heifner mentioned this issue Aug 26, 2023
Merged
@heifner heifner linked a pull request Aug 26, 2023 that will close this issue
IF: Remove recursive implementation of commit #1565
Merged
@heifner heifner removed the OCI Work exclusive to OCI team label Aug 30, 2023
greg7mdp added a commit that referenced this issue Aug 30, 2023
@greg7mdp
Merge branch 'hotstuff_integration' of github.com:AntelopeIO/leap into …
1adc205 
…GH-1553-rm-recursion
greg7mdp added a commit that referenced this issue Aug 31, 2023
@greg7mdp
Merge pull request #1565 from AntelopeIO/GH-1553-rm-recursion
37b5bb0 
IF: Remove recursive implementation of commit
@arhag arhag closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg7mdp greg7mdp

@heifner heifner

Labels
👍 lgtm
Projects
Team Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IF: Remove recursive implementation of commit AntelopeIO/leap
4 participants
@greg7mdp @heifner @arhag @enf-ci-bot