Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leap-4.0.5: non-informative "Connection refused" message for p2p connections #1974

Closed
cc32d9 opened this issue Dec 10, 2023 · 2 comments
Closed
Labels
bug Something isn't working 👍 lgtm
Milestone

Comments

@cc32d9
Copy link
Contributor

cc32d9 commented Dec 10, 2023

4.0.5 and earlier Leap versions.

If a p2p neighbor host exists, but refuses a connection, nodeos logs an error that is difficult to troubleshoot:

error 2023-12-10T20:18:48.407 net-1     net_plugin.cpp:2360           operator()           ] connection failed to 0.0.0.0:0 Connection refused

The error message needs to provide the host and port information.

@bhazzard
Copy link

@heifner this looks like it would be a simple enhancement to include in 6.0.0. Do you agree it doesn't need backporting?

@heifner
Copy link
Member

heifner commented Dec 12, 2023

I believe this is fixed in 5.0. In 5.0 it uses the provided peer address instead. As to if this should be pack-ported to 4.0.x, seems like it should as it is a bug fix.

@bhazzard bhazzard added this to the Leap v4.0.6 milestone Dec 12, 2023
@bhazzard bhazzard added bug Something isn't working 👍 lgtm and removed triage labels Dec 12, 2023
@bhazzard bhazzard modified the milestones: Leap v4.0.6, Leap v4.0.7 Feb 27, 2024
@arhag arhag modified the milestones: Leap v4.0.7, Leap v4.0.8 Mar 20, 2024
@bhazzard bhazzard closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👍 lgtm
Projects
Archived in project
Development

No branches or pull requests

6 participants
@bhazzard @heifner @arhag @cc32d9 @enf-ci-bot and others