Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Update fork-choice rule to consider irreversible block num as soon as possible #2101

Closed
arhag opened this issue Jan 17, 2024 · 1 comment
Closed

IF: Update fork-choice rule to consider irreversible block num as soon as possible #2101

arhag opened this issue Jan 17, 2024 · 1 comment
Labels
discussion

Comments

@arhag
Copy link
Member

arhag commented Jan 17, 2024 •
edited
Loading

Depends on #2125.

Right now we consider the last_final_block_num. But that does not get updated in block_state as soon as a QC is received. It must wait until a new block_state acknowledging the LIB is created.
This was referenced Jan 17, 2024
Closed
Closed
@arhag arhag added discussion and removed triage labels Jan 29, 2024
@arhag
Copy link
Member Author

arhag commented Jan 29, 2024

We do not need this since it was captured into #2125.

@arhag arhag closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
Team Backlog
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arhag @enf-ci-bot