Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ship refactor followup: reimplement or abandon removed session unit test #230

Open
spoonincode opened this issue Jun 4, 2024 · 1 comment

Comments

@spoonincode
Copy link
Member

#96 removed a large unit test that would need to be substantially reworked for the ship refactor. Depending on feedback either abandon the removed tests permanently or reimplement them.

@bhazzard
Copy link

Assess whether the removed test provided any additional coverage.

If not, we should just close this.

If so, is there is a simpler test to provide that coverage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants