Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Failure: ship_streamer_if_test #275

Closed
heifner opened this issue Mar 18, 2024 · 3 comments · Fixed by #236
Closed

Test Failure: ship_streamer_if_test #275

heifner opened this issue Mar 18, 2024 · 3 comments · Fixed by #236
Assignees
Labels
bug The product is not working as was intended. 👍 lgtm

Comments

@heifner
Copy link
Member

heifner commented Mar 18, 2024

https://github.com/AntelopeIO/leap/actions/runs/8330931085/job/22797356430

Fork switch caused some SHiP clients to get incorrect information from SHiP.

A quick look, it appears there is a race on the data in the logs when sending out the data. It can find different blocks by number in the logs according to when the request is sent out.

https://github.com/AntelopeIO/leap/blob/main/plugins/state_history_plugin/include/eosio/state_history_plugin/session.hpp#L527-L527

This failed on an IF run, but it appears to me that this is possible pre-IF.

@linh2931
Copy link
Member

linh2931 commented Mar 20, 2024

Was deep into the SHiP support for IBC. Just notice this issue. I stumbled into the same problem when adding more tests for the IBC work. There is a global variable used in the test file. That caused the problem. I have fixed it in my upcoming commit in AntelopeIO/leap#2321.

This is a pre-IF problem.

@linh2931 linh2931 self-assigned this Mar 20, 2024
@linh2931 linh2931 added bug The product is not working as was intended. and removed triage labels Mar 20, 2024
@linh2931
Copy link
Member

Updated: The problem I fixed was for fork tests in plugins/state_history_plugin/tests/session_test.cpp, not ship_streamer_if_test. This requires further digging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment