Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable upload button song and playlist if required fields not filled #234

Open
AntonioMrtz opened this issue Sep 29, 2024 · 1 comment · May be fixed by #236
Open

Disable upload button song and playlist if required fields not filled #234

AntonioMrtz opened this issue Sep 29, 2024 · 1 comment · May be fixed by #236
Labels
frontend Frontend related issues good first issue Good for newcomers help-wanted Help is wanted

Comments

@AntonioMrtz
Copy link
Owner

Description

Disable upload button song and playlist if required fields not filled. Add some kind of visual marker to distinguish required fields from optional ones. Something like (*) can be used.

Context

Necessary context for understanding the new feature

How to do it

  • In AddSongPlayListAccordion.tsx

Optional fields are:

Playlist

  • Description
  • Thumbnail url

Song

  • Thumbnail url

image

image

Testing

  • Frontend test both for playlist and song upload with required fields non filled
  • Adapt existing tests if needed
@AntonioMrtz AntonioMrtz added good first issue Good for newcomers frontend Frontend related issues help-wanted Help is wanted labels Sep 29, 2024
@AntonioMrtz
Copy link
Owner Author

Disable button for upload song / playlist if form is not fully completed

@SaurabhGurde SaurabhGurde linked a pull request Sep 29, 2024 that will close this issue
Open
@AntonioMrtz AntonioMrtz linked a pull request Sep 30, 2024 that will close this issue
Disable upload button song and playlist if required fields not filled. #236
Open
SaurabhGurde added a commit to SaurabhGurde/SpotifyElectron that referenced this issue Oct 5, 2024
@SaurabhGurde
Merge branch 'AntonioMrtz:master' into fix/AntonioMrtz#234
94d0c96
AntonioMrtz added a commit to SaurabhGurde/SpotifyElectron that referenced this issue Oct 5, 2024
@AntonioMrtz
Merge branch 'master' into fix/AntonioMrtz#234
e7aaf5d
AntonioMrtz added a commit to SaurabhGurde/SpotifyElectron that referenced this issue Oct 5, 2024
@AntonioMrtz
Merge branch 'master' into fix/AntonioMrtz#234
14daedf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend Frontend related issues good first issue Good for newcomers help-wanted Help is wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable upload button song and playlist if required fields not filled. SaurabhGurde/SpotifyElectron
1 participant
@AntonioMrtz