Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support working with eip-1271 messages #12

Open
banteg opened this issue Jun 28, 2023 · 1 comment
Open

support working with eip-1271 messages #12

banteg opened this issue Jun 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@banteg
Copy link
Contributor

banteg commented Jun 28, 2023

Overview

safe transaction service has recently added support for aggregating signatures for off-chain messages.

the flow for them is similar to transactions, except they never get executed and instead are passed to other contracts, that check isValidSignature. for example, this enables sending cowswap orders in a completely off-chain manner.

we could support them via AccountAPI.sign_message

Specification

see here for an example/reference:
https://gist.github.com/banteg/68ad51b133d447aa4a165bea0c7b91a1

see here for the client api:
https://safe-transaction-mainnet.safe.global/

Dependencies

depends on ApeWorX/ape#1508

@banteg banteg added the enhancement New feature or request label Jun 28, 2023
@fubuloubu
Copy link
Member

One thing to keep in mind is that the way they are treated in safe UI is as a blocking call. If you want your 1271 signature back, you will have to wait for all signers to sign. You can use it as a way to kick off signatures for what you have locally, but then receive None back, and then you should go and fetch the signatures from the API using the client (or another wrapper method)

Something to consider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants