Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: test accounts __repr__ and some refactoring of generated accounts #2444

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

perf: test accounts __repr__ and some refactoring of generated accounts #2444

wants to merge 3 commits into from

Conversation

antazoey
Copy link
Member

small perf

fixes: #2436
Fixes: APE-1865

BEFORE:

In [1]: %time accounts.test_accounts
Wall time: 17.1 ms
Wall time: 10 μs

In [1]: %time accounts.test_accounts[5]
Wall time: 329 ms
Wall time: 30 μs

In [1]: %time accounts.test_accounts[0].address
Wall time: 344 ms
Wall time: 250 μs


AFTER:

In [1]: %time accounts.test_accounts
Wall time: 10.4 ms
Wall time: 7.87 μs

In [1]: %time accounts.test_accounts[5]
Wall time: 335 ms
Wall time: 34.1 μs

In [1]: %time accounts.test_accounts[0].address
Wall time: 325 ms
Wall time: 38.9 μs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve performance of accounts.test_accounts
1 participant
@antazoey