Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Logs in transaction trace #834

Closed
antazoey opened this issue Jun 28, 2022 · 3 comments · Fixed by #2161
Closed

Include Logs in transaction trace #834

antazoey opened this issue Jun 28, 2022 · 3 comments · Fixed by #2161
Labels
category: feature New feature or request

Comments

@antazoey
Copy link
Member

Overview

Foundry is able to include events in the logs... so should we!
IMAGE 2022-06-28 11:22:01

NOTE: This may only be possible in the geth style logs.

Specification

See image ! But make fit in . Use your favorite ape crayon colors (pick a new color for the event name but use the input color for the inputs)

Dependencies

Might need to add support in evm-trace first: ApeWorX/evm-trace#9

@antazoey antazoey added the category: feature New feature or request label Jun 28, 2022
@fubuloubu
Copy link
Member

Do you mean displaying logs when printing the tree? Or do you mean logging the events that occur within any transaction you broadcast to the network?

@banteg
Copy link
Contributor

banteg commented Jul 10, 2022

one thing to consider is parity-style traces only contain calls and no logs. so this would only by possible with geth-style logs by catching LOG0...LOG4 opcodes.

@fubuloubu
Copy link
Member

one thing to consider is parity-style traces only contain calls and no logs. so this would only by possible with geth-style logs by catching LOG0...LOG4 opcodes.

Could probably fill in logs by finding LOG* opcodes and tracing it back to raw topics/data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants