Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .encode() #51

Open
poolpitako opened this issue Apr 24, 2024 · 4 comments
Open

Add .encode() #51

poolpitako opened this issue Apr 24, 2024 · 4 comments

Comments

@poolpitako
Copy link

Overview

Provide a simple overview of what you wish to see added. Please include:

  • I would like my class extending EIP712Message to have an encode() method.
Copy link

linear bot commented Apr 24, 2024

APE-1734 Add .encode()

@fubuloubu
Copy link
Member

thinking further, since this class is a dataclass it's usually not wise to add another method to it, but we can just make a pure function abi_encode_struct that does the same thing

@poolpitako
Copy link
Author

thinking further, since this class is a dataclass it's usually not wise to add another method to it, but we can just make a pure function abi_encode_struct that does the same thing

why that logic doesn't apply to signable_message()?

@fubuloubu
Copy link
Member

thinking further, since this class is a dataclass it's usually not wise to add another method to it, but we can just make a pure function abi_encode_struct that does the same thing

why that logic doesn't apply to signable_message()?

it probably should lol, but would be more annoying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants