Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add broadcast card in grades page #909

Closed
wants to merge 5 commits into from
Closed

Add broadcast card in grades page #909

wants to merge 5 commits into from

Conversation

HugoMigner
Copy link
Contributor

⁉️ Related Issue

Closes #897

📖 Description

Add the broadcast card, recently developed for the dashboard, in the grades page. This will allow for easier visibility for the users.

🧪 How Has This Been Tested?

Modify existing tests in grades page.

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.
  • Make sure golden files changes were reviewed and approved.

🖼️ Screenshots (if useful):

image

@HugoMigner HugoMigner requested a review from a team as a code owner December 8, 2023 13:42
@HugoMigner HugoMigner closed this Dec 8, 2023
@HugoMigner HugoMigner reopened this Dec 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Coverage after merging feature/broadcast-card-grades into master will be

77.85%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib
   locator.dart4.35%100%100%4.35%28, 30–42, 45–49, 52–54
lib/core/constants
   preferences_flags.dart0%100%100%0%64, 69, 71, 73–75, 78, 80–83, 85, 87
   emergency_procedures.dart100%100%100%100%
   markers.dart100%100%100%100%
   quick_links.dart100%100%100%100%
   widget_helper.dart100%100%100%100%
lib/core/managers
   cache_manager.dart0%100%100%0%30–31, 34–37, 40, 44, 46–49, 51, 59, 61–63, 65, 72, 74–77
   course_repository.dart96.74%100%100%96.74%242, 250, 252–253, 428–429, 500
   quick_link_repository.dart85.71%100%100%85.71%39–40
   settings_manager.dart88.98%100%100%88.98%217, 223, 226, 230, 232, 252, 254–255, 268, 270–272, 39, 88
   user_repository.dart94.50%100%100%94.50%294–296, 95–97
lib/core/models
   quick_link.dart100%100%100%100%
   quick_link_data.dart100%100%100%100%
   feedback_issue.dart100%100%100%100%
   emergency_procedure.dart100%100%100%100%
   widget_models.dart100%100%100%100%
   discovery.dart100%100%100%100%
   group_discovery.dart100%100%100%100%
   faq_actions.dart100%100%100%100%
   faq_questions.dart100%100%100%100%
lib/core/services
   analytics_service.dart0%100%100%0%16–17, 20, 23–25, 28, 33, 35–37, 41–43, 45
   app_widget_service.dart80%100%100%80%71, 73–78
   github_api.dart0%100%100%0%100, 103, 108, 110–114, 116–117, 120, 128–131, 135–136, 138, 39, 42–43, 47, 51–55, 57–58, 60, 62, 64–65, 68, 76, 81–87, 91, 93, 95–97, 99
   in_app_review_service.dart0%100%100%0%16, 20, 23, 27
   internal_info_service.dart0%100%100%0%18–21, 24–29, 32, 34–38, 42–43
   launch_url_service.dart0%100%100%0%22–24, 27–29, 32–33, 35–36, 42, 60–61, 64
   navigation_service.dart0%100%100%0%21, 24–26, 33–36, 38–39, 44, 47–49, 51–52
   networking_service.dart0%100%100%0%10–11, 13–15, 18–20
   preferences_service.dart68.52%100%100%68.52%120–121, 123, 37, 39, 41, 44–46, 70–71, 81–83, 86, 88–89
   remote_config_service.dart0%100%100%0%102–104, 107–109, 112–114, 117–118, 120–123, 125, 130–132, 47–49, 52–54, 57–59, 62–64, 67–69, 72–74, 77–79, 82–84, 87–89, 92–94, 97–99
   rive_animation_service.dart0%100%100%0%13–14, 17, 20–21, 29, 33–34, 36
   siren_flutter_service.dart0%100%100%0%13–14, 18–19, 23–25, 29–31, 35, 41
lib/core/utils
   cache_exception.dart33.33%100%100%33.33%13, 15
   animation_exception.dart20%100%100%20%18, 20–22
   utils.dart70.83%100%100%70.83%12–15, 17–18, 50
   login_mask.dart5%100%100%5%12, 15–16, 18–20, 23–30, 33–34, 37–39
lib/core/viewmodels
   emergency_viewmodel.dart7.69%100%100%7.69%21–22, 24–25, 27–29, 33, 35–36, 43–44
   security_viewmodel.dart50%100%100%50%37–38, 42–44, 46, 51–52
   dashboard_viewmodel.dart82.85%100%100%82.85%146–148, 150, 153, 240–241, 255–259, 261, 270–271, 313, 353–355, 360, 463, 479–481, 483, 488–489, 546–547, 552, 554, 556, 558, 560, 563–564, 566, 569, 571, 573–574, 576–577, 580–581, 593–594
   schedule_settings_viewmodel.dart77.38%100%100%77.38%117–121, 137, 139, 141, 144, 147, 149–150, 64, 66–71
   schedule_viewmodel.dart81.48%100%100%81.48%100–105, 107, 122, 157–163, 199, 265, 270–271, 306, 349–353, 362–363, 384–387, 390–391, 423–424
   grades_details_viewmodel.dart97.22%100%100%97.22%61
   settings_viewmodel.dart100%100%100%100%
   profile_viewmodel.dart92.45%100%100%92.45%129–130, 78, 81
   quick_links_viewmodel.dart100%100%100%100%
   web_link_card_viewmodel.dart62.50%100%100%62.50%35, 40–41
   grades_viewmodel.dart97.01%100%100%97.01%148–149
   choose_language_viewmodel.dart100%100%100%100%
   more_viewmodel.dart68%100%100%68%109–111, 113–114, 116, 121–122, 141–142, 144–145, 147–148, 151–152
   login_viewmodel.dart100%100%100%100%
   not_found_viewmodel.dart100%100%100%100%
   faq_viewmodel.dart41.67%100%100%41.67%30, 32–33, 35, 38, 41, 43
   feedback_viewmodel.dart79.41%100%100%79.41%63–64, 66–68, 70–71
   startup_viewmodel.dart92.50%100%100%92.50%103, 138–139
lib/ui/utils
   app_theme.dart0%100%100%0%6, 72–74, 77–82, 86–88, 94–99
   discovery_components.dart93.23%100%100%93.23%102, 133, 164, 194, 224, 40, 458, 465–466, 468, 470–475, 71
   loading.dart100%100%100%100%
lib/ui/views
   security_view.dart75.41%100%100%75.41%108, 110–114, 45–47, 66–71
   emergency_view.dart52.17%100%100%52.17%34–40, 51–54
   dashboard_view.dart79.58%100%100%79.58%159–161, 169–172, 180–182, 190–192, 200–202, 240–243, 257–259, 265–267, 275, 277–278, 296–299, 303–305, 331–332, 369–370, 382–383, 418–419, 466–468, 513, 90
   schedule_view.dart47.92%100%100%47.92%104–109, 111–112, 114–115, 117–121, 123–124, 126–127, 138, 158, 160, 162, 165, 168, 172, 174–175, 178, 182, 189–194, 196–197, 200, 205, 210, 216, 218–219, 221, 223, 225, 228, 232–233, 235–236, 238–242, 244, 246, 248, 253, 259–262, 265&nda

JonathanDuvalV
JonathanDuvalV reviewed Dec 8, 2023
View reviewed changes
lib/ui/views/grades_view.dart
@@ -114,6 +119,80 @@ class _GradesViewState extends State<GradesView> {
),
);

Widget _buildMessageBroadcastCard(GradesViewModel model) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a exactement la même méthode dans broadcast_view si je ne me trompes pas. Peut-etre ca serait worth de les extraire et faire un component reutilisable avec ?

camillebrulotte
camillebrulotte previously approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@camillebrulotte camillebrulotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@EffBureau
Copy link
Contributor

Cette PR est-elle encore valide?

@XavierPaquet-Rapold
Copy link
Contributor

XavierPaquet-Rapold commented Jun 18, 2024 •
edited
Loading

@EffBureau il faudrait merge et créer un Widget réutilisable pour la broadcast card. La seule raison que je garde cette PR ouverte est pour rappeler qu'il faut le faire.

@XavierPaquet-Rapold XavierPaquet-Rapold marked this pull request as draft June 18, 2024 03:02
@XavierPaquet-Rapold XavierPaquet-Rapold deleted the feature/broadcast-card-grades branch July 18, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanDuvalV JonathanDuvalV JonathanDuvalV left review comments

@camillebrulotte camillebrulotte camillebrulotte left review comments

Assignees
No one assigned
Labels
size: M version: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable the display of the broadcast card on the grades page
5 participants
@HugoMigner @EffBureau @XavierPaquet-Rapold @camillebrulotte @JonathanDuvalV