Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - asis bug in modal functions #437

Merged
merged 5 commits into from
May 4, 2023
Merged

Fix - asis bug in modal functions #437

merged 5 commits into from
May 4, 2023

Conversation

federiva
Copy link
Contributor

@federiva federiva commented Apr 27, 2023

Closes #426

How to test:

You can test the example shiny app reproducing the error that was submitted in the issue description

image

DoD

  • Major project work has a corresponding task. If there’s no task for what you are doing, create it. Each task needs to be well defined and described.

  • Change has been tested (manually or with automated tests), everything runs correctly and works as expected. No existing functionality is broken.

  • No new error or warning messages are introduced.

  • All interaction with a semantic functions, examples and docs are written from the perspective of the person using or receiving it. They are understandable and helpful to this person.

  • If the change affects code or repo sctructure, README, documentation and code comments should be updated.

  • All code has been peer-reviewed before merging into any main branch.

  • All changes have been merged into the main branch we use for development (develop).

  • Continuous integration checks (linter, unit tests) are configured and passed.

  • Unit tests added for all new or changed logic.

  • All task requirements satisfied. The reviewer is responsible to verify each aspect of the task.

  • Any added or touched code follows our style-guide.

@federiva federiva requested review from jakubnowicki and osenan April 27, 2023 21:34
Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One comment - please update the package version to 0.4.3.9000

@federiva federiva merged commit 4b00b7c into develop May 4, 2023
@federiva federiva deleted the 426.fix-asis branch May 4, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: modal function does not handle JS callbacks
2 participants