-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot view or delete a record that contains Map data #34
Comments
@chasevida Thanks for warm words. I wish you to know that i made this GUI when i had no experience in development. Now i get some and i think i need to rewrite some weird parts of this app. I will investigate the bug soon, i think that there is a problem when passing data to editor. Can you please switch to 'code' mode of the editor and make sure if it's empty too? All fixes and new features will be released this weekend. |
Thanks @Arattian, I'm really impressed you did this with no experience before hand - nice job! It's definitely the nicest Gui for DynamoDB that I've found so you've done well pulling it all together. I tried the |
@chasevida Thanks a lot. I am reviewing this too, I hope to fix this within the next release at the weekend. |
No pressure from me by the way, appreciate this is open source and as such your time. Just thought I'd log it here and if I get a chance to fix it before you I'll make a PR. |
There will be no release this week. I decided to rewrite the project, to make it easy to contribute. Please be patient :) Thanks for understanding. |
No worries. Let me know if there is anything I can help with. |
I investigated this bug a bit since I hit a similar one and I don't believe that this is related to Map data but rather number/non string keys. In my case, and I believe in @chasevida's case as well, we're using a number that's too large to be represented by Javascript, which means that details will be lost when using the DocumentClient to get or update the data. What is likely happening is that we fail to get the record while opening the modal which leads to an empty one. It'd also explain delete failing since delete would require the key. |
Describe the bug
Cannot expand (view as a modal) or delete a record row that contains DynamoDB Map data.
To Reproduce
Steps to reproduce the behaviour:
4.a Double click the record in the table list view
5.a The record should display in the modal but in actuality the modal displays empty/no record data.
4.a Click the rows trash icon in order to delete the record
4.b Click confirm delete - it does not delete the record
Expected behavior
Screenshots
The below shows a record containing 'map' data.
The below shows what the record displays as when expanded into the modal view. You can see that it shows as empty instead of showing the nested data structure.
The delete operation does not work on this row either.
Desktop (please complete the following information):
Additional context
I'd be keen to help solve this and have started looking through the code. It just may take me a little while to get familiar with the setup and understand how Vue works.
Thank you
I just wanted to say a big thanks for this DynamoDB Gui. I tried a few alternatives before landing on this and I really appreciate the effort you have put in. It's a great client and it's a pleasure to work with. Thanks!!!
The text was updated successfully, but these errors were encountered: