Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_DDS - no tests #27925

Open
Ryanf55 opened this issue Aug 26, 2024 · 1 comment
Open

AP_DDS - no tests #27925

Ryanf55 opened this issue Aug 26, 2024 · 1 comment

Comments

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Aug 26, 2024

Bug report

Issue details

Something appears to have broken in the colcon tests. None of them are executed.

Please describe the problem

Version
master, 4.5.

Platform
[ ] All
[ ] AntennaTracker
[ ] Copter
[ ] Plane
[ ] Rover
[ ] Submarine

Logs

$ colcon build --packages-up-to ardupilot_dds_tests
Starting >>> ardupilot_msgs
Finished <<< ardupilot_msgs [0.36s]                     
Starting >>> ardupilot_sitl
Finished <<< ardupilot_sitl [5.18s]                    
Starting >>> ardupilot_dds_tests
/home/ryan/.local/lib/python3.10/site-packages/setuptools/_distutils/dist.py:268: UserWarning: Unknown distribution option: 'tests_require'
  warnings.warn(msg)
--- stderr: ardupilot_dds_tests                   
/home/ryan/.local/lib/python3.10/site-packages/setuptools/_distutils/dist.py:268: UserWarning: Unknown distribution option: 'tests_require'
  warnings.warn(msg)
---
Finished <<< ardupilot_dds_tests [1.09s]

Summary: 3 packages finished [7.10s]
  1 package had stderr output: ardupilot_dds_tests
$ . install/setup.bash
$ colcon test --packages-select ardupilot_dds_tests --event-handlers=console_cohesion+
Starting >>> ardupilot_dds_tests
/home/ryan/.local/lib/python3.10/site-packages/setuptools/_distutils/dist.py:268: UserWarning: Unknown distribution option: 'tests_require'
  warnings.warn(msg)
--- output: ardupilot_dds_tests                   

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
---
--- stderr: ardupilot_dds_tests

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
---
Finished <<< ardupilot_dds_tests [0.33s]

Summary: 1 package finished [0.79s]
  1 package had stderr output: ardupilot_dds_tests
$ colcon test-result --all --verbose
Summary: 0 tests, 0 errors, 0 failures, 0 skipped
@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Sep 7, 2024

ArduPilot is hosing the test environment.

Here, we install the apt version of setuptools

SITL_PKGS="libtool libxml2-dev libxslt1-dev ${PYTHON_V}-dev ${PYTHON_V}-pip ${PYTHON_V}-setuptools ${PYTHON_V}-numpy ${PYTHON_V}-pyparsing ${PYTHON_V}-psutil"

Then, this PR hoses the system install of setuptools with an ABI breaking version, and does it on the host OS.
#27689

This ticket still stands:
#26137

We need to be using a virtual environment if we are overwriting system installs with ABI breaking changes. It's not fair to developers who work outside of ArduPilot to overwrite the system packages with local ABI breaking versions .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant