Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDS: Validate ROS_DOMAIN_ID environment is the same as DDS_DOMAIN_ID #28046

Open
Ryanf55 opened this issue Sep 8, 2024 · 0 comments
Open

DDS: Validate ROS_DOMAIN_ID environment is the same as DDS_DOMAIN_ID #28046

Ryanf55 opened this issue Sep 8, 2024 · 0 comments
Labels
Enhancement ROS

Comments

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Sep 8, 2024 •
edited
Loading

Feature request

Is your feature request related to a problem? Please describe.

If someone sets the ROS_DOMAIN_ID and it doesn't match their DDS_DOMAIN_ID, they can't communicate with the vehicle over DDS

Describe the solution you'd like

In sitl.launch.py , use pymavlink to read the DDS_DOMAIN_ID param, and issue a warning if it doesn't match the environment variable ROS_DOMAIN_ID

Describe alternatives you've considered

The wiki explains this, but people miss it from time to time

Platform
[ x ] All
[ ] AntennaTracker
[ ] Copter
[ ] Plane
[ ] Rover
[ ] Submarine

Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement ROS
Projects
DDS/ROS2
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ryanf55