Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for --no-color and $NO_COLOR #62

Open
Arinerron opened this issue Oct 18, 2021 · 2 comments
Open

Add support for --no-color and $NO_COLOR #62

Arinerron opened this issue Oct 18, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone
3.0

Comments

@Arinerron
Copy link
Owner

options:

  • write a wrapper for fprintf to strip ANSI maybe?
  • provide an alternate non-color string in every logging function?
  • make a COLOR() printf macro and split out every color into separate printfs?
  • use %s and (OPT_NO_COLOR ? "" : COLOR_...)?
@Arinerron Arinerron added the enhancement New feature or request label Oct 18, 2021
@Arinerron Arinerron added this to the 3.0 milestone Oct 18, 2021
@Arinerron Arinerron changed the title Add support for --no-color and $NO_COLOR Add support for --no-color and $NO_COLOR Oct 18, 2021
@Arinerron
Copy link
Owner Author

COLOR() printf might be best so we can collect nbytes_written += printf(...) in the future when we align stuff with nbytes

@Arinerron
Copy link
Owner Author

7f70389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@Arinerron