Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixies for upload implementation #4

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fixies for upload implementation #4

merged 1 commit into from
Nov 8, 2024

Conversation

AnatoliyProjects
Copy link
Contributor

  1. Added workaround for Safari browser, where input.click() doesn't work.
  2. Added event listener for cancel event. Otherwise, a callback will never be called in this case.
  3. Fixed std::string_view ctor call.
  4. Added desired information in README.md.

Issues:
Resolves #3

@AnatoliyProjects
Fixies for upload implementation
3f27938 
1) Added workaround for Safari browser, where input.click() doesn't work.
2) Added event listener for <input> cancel event.  Otherwise, a callback will never be called in this case.
3) Fixed  std::string_view ctor call.
4) Added desired information in README.md.
@slowriot slowriot merged commit d21dec7 into Armchair-Software:main Nov 8, 2024
@slowriot
Copy link
Member

slowriot commented Nov 8, 2024

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not working on iOS/iPadOS?
2 participants
@AnatoliyProjects @slowriot