Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize MainModule #418

Open
cwbriones opened this issue Jun 20, 2020 · 0 comments
Open

Modularize MainModule #418

cwbriones opened this issue Jun 20, 2020 · 0 comments

Comments

@cwbriones
Copy link
Contributor

I'm filing this issue because the MainModule just reached 1k+ lines, I had to add a linter exception for it.

Since MainModule encapsulates all DI bindings for the application, it has grown extremely large and somewhat difficult to navigate.

We should modularize the bindings by domain and install them from within the MainModule. Things should also keep package boundaries neat since nobody other than the domain-specific module should have to import the xxx.impl packages.

Examples: AlertModule, ReportingModule, RollupModule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cwbriones