default ebean.properties with UTC timezone #432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My thought process in adding this default is that we're making this usage explicit, and by doing it through standard configuration anyone who's deployed mportal without configuring this can continue to do so by changing the timezone in |
|
Alternatively - since this is properties file I might be mistaken in how easily overridden this is. If that's a problem I think we'll just have to resort to setting it ourselves in our deployment. |
|
Closing since I think it's another source of configuration that could actually go out of sync (rather than a single source, the JVM's timezone). Additionally the prior issue seems mostly like a test isolation problem rather than one with the system during normal operation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #419.
See the issue for details. The short of it is that we already treat all unzoned times internally as UTC, mostly through the usage of
Instant. Ebean by default however, uses the JVM timezone when it initializes its connection pool. This previously caused issues in tests, and so it was explicitly set to UTC there. This PR does the same by adding a default properties file.