Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the display-dependency-updates goal #487

Open
cwbriones opened this issue Feb 12, 2021 · 1 comment
Open

Re-enable the display-dependency-updates goal #487

cwbriones opened this issue Feb 12, 2021 · 1 comment

Comments

@cwbriones
Copy link
Contributor

The plugin (org.codehaus.mojo:versions-maven-plugin:2.5:display-dependency-updates) was explicitly disabled for this project in #486. This is because of suspected issues with the maven http client within the Github Actions environment.

Once those issues are resolved we need to re-enable this plugin.

@cwbriones
Copy link
Contributor Author

The initial workaround was introduced in #483 but doesn't seem to help here.

cwbriones added a commit that referenced this issue Feb 12, 2021
Fixes a bug with reloads that occurs as follows:
* Job begins executing and sets the currentlyExecutingFlag
* Anti-entropy kicks in and sends a `Reload` message.
* Reload thinks that it's been triggered by the completion of a job, and so clears the currentlyExecuting flag
* Reload completes and immediately kicks off a second execution (via tick).

This makes it so we only clear the execution flag if we're sure the Reload message occurred internally, otherwise it's ignored since we'll already reload when the execution completes.

Additionally some changes were necessary to our build to deal with issues in GA
* Updated Maven to 3.6.3 (latest)
* Disabled the display-dependency-updates goal. See #487.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant