Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up for #45 - separate Message values to a separate constant class #46

Closed
wolframhaussig opened this issue Oct 23, 2023 · 0 comments · Fixed by #49
Closed

Follow up for #45 - separate Message values to a separate constant class #46

wolframhaussig opened this issue Oct 23, 2023 · 0 comments · Fixed by #49

Comments

@wolframhaussig
Copy link
Contributor

As part of #45, we implemented a solution for handling native errors. To make this easier, we provided the name of the msg-value in calls to SendMessage. This mapping from the value to the constant name causes issues as the same value may exist in multiple constants which have different meanings. Therefore, we should separate the constants that represent msg values into a separate class.

@wolframhaussig wolframhaussig mentioned this issue Oct 31, 2023
2 tasks
@wolframhaussig wolframhaussig linked a pull request Oct 31, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant