Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardize rolecert and role cert #45

Open
WindzCUHK opened this issue Oct 25, 2023 · 2 comments
Open

standardize rolecert and role cert #45

WindzCUHK opened this issue Oct 25, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@WindzCUHK
Copy link
Contributor

WindzCUHK commented Oct 25, 2023 •
edited
Loading

issue: short form should be 1 word or 2 words

  • ENV
    • ROLECERT_DIR
    • ROLE_CERT_FILENAME_DELIMITER
    • ROLE_CERT_KEY_FILE_OUTPUT
  • args
    • rolecert-dir
    • rolecert-key-file-output
  • log message
  • internal stuff (variable name, etc.)

sidetrack

  • SERVICEACCOUNT => SERVICE_ACCOUNT?
@mlajkim
Copy link
Contributor

mlajkim commented Nov 2, 2023

I thought of this too ! haha

@mlajkim mlajkim added the enhancement New feature or request label Nov 16, 2023
@mlajkim
Copy link
Contributor

mlajkim commented Sep 6, 2024

The standard will be ROLE_CERT not ROLECERT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WindzCUHK @mlajkim