Feature/issue history - make retrieval of history dependent on GetHistory argument/parameters switch #441
Conversation
|
Is there any chance this will get picked up? I'm not familiar with the community/process, but I think the change is useful and fairly cleanly implemented. |
There was a problem hiding this comment.
This file is missing documentation docs/en-US/commands/Get-JiraStatus.md and tests Tests/Functions/Get-JiraStatus.Unit.Tests.ps1.
JiraPS/Public/Get-JiraIssue.ps1
Outdated
There was a problem hiding this comment.
Tests/Functions/Get-JiraIssue.Unit.Tests.ps1 needs to be extended with this new functionality.
JiraPS/Public/Invoke-JiraMethod.ps1
Outdated
There was a problem hiding this comment.
can you elaborate on why this change is necessary?
There was a problem hiding this comment.
I don't remember precisely anymore, because it's been a long time since I did this work. I think it had to do with the "toString" identifier colliding with a .NET method, and this was the simplest way I could think of to avoid that collision.
| param( | ||
| [Parameter( Mandatory, ValueFromPipeline, ParameterSetName = '_Search' )] | ||
| [String[]] | ||
| $IdOrName, |
There was a problem hiding this comment.
Please rename variable to $Status to be analog to similar implementations.
eg JiraPS/Public/Get-JiraField.ps1
The documentations should elaborate on what values are allowed to be used for the parameter.
of getting the history of issues (or not).
lipkau
force-pushed
the
feature/IssueHistory
branch
from
be9fefb
to
3e80c82
Compare
Description
Introduce the argument/parameter GetHistory to allow control of fetching issue history at call site
Motivation and Context
Getting the history is very useful, but it would be even better if it can be a choice at the call site.
Types of changes
Checklist