Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Short EAL #19895

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Short EAL #19895

merged 2 commits into from
Sep 21, 2024

Conversation

Geevies
Copy link
Contributor

@Geevies Geevies commented Sep 13, 2024

  • EAL is now much shorter to people who can't understand it, to represent how effective it is at compressing communicated datapackets.
  • Fixed scrambled languages causing double spaces and uncapitalized words.

Showing how the shortened message looks:
image
image

Showing the effect of the bugfix:
image

@NobleRow
Copy link
Contributor

I am lore guy and I approve this message.

@Geevies
Copy link
Contributor Author

Geevies commented Sep 13, 2024

!review

FluffyGhoster
FluffyGhoster approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@FluffyGhoster FluffyGhoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise, not sure on the logic part but ¯\(ツ)/¯

@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Sep 21, 2024
Merged via the queue into Aurorastation:master with commit 6572cf3 Sep 21, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NonQueueingMatt NonQueueingMatt NonQueueingMatt approved these changes

@FluffyGhoster FluffyGhoster FluffyGhoster approved these changes

Assignees
No one assigned
Labels
Awaiting Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Geevies @NobleRow @NonQueueingMatt @FluffyGhoster @BotBOREALIS