-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engineering lobby expansion #19945
Engineering lobby expansion #19945
Conversation
(Room merge, notice board, FAK locker, utils)
!review |
Fixed wrong tile in hardstorage, fixed wrong decal in shield gen room, nudged items in lobby, swapped wall mounted objects in lobby, add hazard stripes to metal tables, add air alarm to medical-engineering hallway
Latest commit didn't only feature refactoring, but should also fix the CI blocked by duplicate grates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its an existing thing from before your PR, but do you think you could move the engineering ringer button onto the desk please? Other than that, this all looks great. I'm slightly hesitant about a bigger engineering lobby given the impact the one we had a few years ago had. But I'd at least like to try your changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two main concerns here:
- I do not particularly like big lobbies - it's the kind of thing we tried to expunge from the Aurora for good reason. People would clump up in these big lobbies, fundamentally out of sight from the public (note how the current lobbies have no blind spots from the hallway immediately outside, whereas your lobby now has one to the left) and thus cutting them off from interaction from the outside. This is a core element of Horizon design philosophy.
- The two tile hallway to the south is really bad for mobility, especially since it's often trafficked, and especially by security for chasing antagonists.
Done with 4ecbf46 |
Regarding A)
Regarding B) I am not sure if this is common practice, maybe we could make a test-merge out of this? |
I'm not convinced making it bigger would be a positive either |
Sorry to hear, what concerns you about it? Similar concerns as Matt named? |
Agree with Matt's concerns. This makes it so the lobby is the department entrance, and non-engineers can't enter the department without going through the lobby. Other departments have entrance and lobby separate. |
Operations has a lobby that also functions as main entrance to the department, i don't see any issues with that. |
I see three ways on how we could continue:
Let me know what you think is appropriate. @NonQueueingMatt, @DreamySkrell, @FluffyGhoster Appendum |
After getting additional input from @NonQueueingMatt on the mentioned concerns, i have decided to close this PR and come back with a new one to address the issues. |
Introduction
This PR has the goal to revamp the engineering lobby. In this PR the lobby itself and the areas adjacent to it have been modified, the adjacent areas as necessary.
Why?
The current engineering lobby is very small. With four to five engineers, the lobby can already be considered full. It becomes especially cluttered when every table is stacked to the ceiling with different stuff and one or two crates are lying around. Generally - The lobby feels too small and is just a simple cube. Engineering lobbies should be a bit wider open as they feature the cut between clean hallways, monitoring and paperwork, and the oily heavy-duty equipment next door.
What changed?
Desks, notice board, consoles and equipment area next to it, feels like engineering.
No more wiring sheets lying around.
I broke a window, sorry guys!
For the lazy doctors coming from residential and security waiting to get in.
No more bleeding out, remember that locker.
I could not resist them.
Prototype, test, refine.
Preview
Lobby
Public facing hallway
Engineering-medical hallway
StrongDMM overview
Addendum/Edit
Updating Preview pictures and What-changed to latest commit.