Update __init__.py #144
Open
Update __init__.py #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify creation_date time string to match CORDEX SOD
Update __init__.py to add cell_methods to instantaneous variables
Removes trailing decimals from lat/lon grid and rounds to number of decimals specified in user's domain.json file
Cleaned up __init__.py, modified cell_methods to include "area: mean", rounded lat_bnds, lon_bnds and removed _FillValue
|
@ngben, is this still relevant. There is no one assigned to it. |
|
Yeah it's still relevant, we needed to make some changes to fix the timestamp and lat/lon floating points to meet CORDEX specifications/CF compliance. cell_methods might be changed again in the future. |
We're going to need to wrap some tests around this. For some reason the Actions are not triggering on the repo so there is not visibility as to what this change will do to the package stability. I'll raise another issue to get tests up and running again before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify creation_date time string to match CORDEX SOD (“2023-01-15T14:30:23Z”)