Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revit 2023.1.1 classifications settings are not exported propperly #556

Open
EtiennevdBa opened this issue Dec 2, 2022 · 72 comments
Open
Labels
2023 version export Issue with exporting process or results in progress Issue currently being addressed by developer parameters-properties Error in resulting Revit parameter or IFC properties/property sets problem Something isn't working Revit

Comments

@EtiennevdBa
Copy link

Dear Revit/ifc team,

when i create a IFC file in Revit 2023.0.2 with the default exporter the classifications settings are exported propperly
image
image
when i export a IFC file in Revit 2023.0.2 with the opensource exporter 23.1.1.0 the classifications setting are not exported correctly
image
image

These issues are also in Revit 2023.1.1 with and without the opensource exporter.
are there more people with these issues?

Kind regards,

Étienne

@AngelVelezSosa
Copy link
Contributor

I believe this is a known issue with Solibri that has already been fixed.

@EtiennevdBa
Copy link
Author

EtiennevdBa commented Dec 2, 2022

I believe this is a known issue with Solibri that has already been fixed.

Dear AngelVelezSosa,

thanks for your response.
It's not Solibri related, when i open the IFC file in BIMvision i'm having the same issue.
Here is the same project in BIMvision with the classifications settings propperly exported:
image
image

Here it is not propperly exported:
image
image

Also tried the new 23.2.3.0 exporterd, same result:
image
image

Here are my classification settings within the IFC exporter:
image
what i don't understand is even with a filled in 'documentation location' there is other information in the IFC file.

If there is more information needed, please let me know.

@AngelVelezSosa AngelVelezSosa reopened this Dec 2, 2022
@AngelVelezSosa
Copy link
Contributor

I'll ask @WawanSolihin to check, but I think this might still be a viewer issue (#546, I think?)

@benjaminchvn
Copy link

Hi,

I am facing the same issue with classification, with Revit 2023.1 and IFC exporter 23.2.1.0.
Here are my classification settings :
ClassifSettings
I tested with a simple wall with "ClassificationCode" shared type parameter filled this way :
TypeParameter

Here is the incorrect result with BIM Vision :
R23-BimVision
This is the same in Solibri :
Solibri R23

It seems, as @EtiennevdBa noticed that IfcClassificationReference.Name and IfcClassificationReference.Location are not set up properly during export

@benjaminchvn
Copy link

Here is also the comparison of correct (with Revit 20) and incorrect export (with Revit 2023.1 and IFC exporter 23.2.1.0) with BIMCollab :
bimcollab

@louistrue
Copy link

@benjaminchvn @EtiennevdBa
Have a look here: #546
It's a mix of Revit doing something unusual and nearly all viewers having a bug where they dont read IfcClassification.Name but IfcRelAssociatesClassification.Name instead, which isn't the correct place to read the Classification Name from according to the IFC schema...

@WawanSolihin
Copy link
Contributor

There seems to be a real regression bug also in Revit IFC exporter:

  1. The classification reference name is not set correctly (It takes the classification name instead. "MyClassif" in the above example)
  2. IfcClassificationReference.Location picks up the wrong value (from the default or previous value of Uniformat.
  3. In IFC4 export it may not export the classification

I will log a defect on this issue.

@benjaminchvn
Copy link

Thanks ! Hope this can be fixed.
I was also wondering if there is any way to override the Defaut Classification (Uniformat) associated with the use of built-in Revit assembly code (Name, Source and Edition) :
Defaut
So far the only way I have found is to manually edit the IFC in notepad....

@EtiennevdBa
Copy link
Author

@benjaminchvn well, editing the IFC in notepad is quite fun.
I hope that there will be a fix soon :)

@JOuellette-Autodesk JOuellette-Autodesk added problem Something isn't working in progress Issue currently being addressed by developer export Issue with exporting process or results parameters-properties Error in resulting Revit parameter or IFC properties/property sets 2023 version Revit labels Jan 5, 2023
@JOuellette-Autodesk
Copy link
Contributor

@WawanSolihin
Copy link
Contributor

Thanks ! Hope this can be fixed. I was also wondering if there is any way to override the Defaut Classification (Uniformat) associated with the use of built-in Revit assembly code (Name, Source and Edition) : Defaut So far the only way I have found is to manually edit the IFC in notepad....

What exactly are you trying to override this?

@benjaminchvn
Copy link

Hi, in this case I am using Assembly code in Revit to fill in Uniformat classification code, but version II 2015, so source and edition are not correct.

@WawanSolihin
Copy link
Contributor

Hmm, currently the Uniformat classification information is hardcoded based on the version Revit has internally and therefore cannot be overridden.

@xpt5
Copy link

xpt5 commented Feb 1, 2023

If it sheds some light over the issue, the problem also can be found with Revit 2022.1.1 and the following Ifc Exporter versions:

  • v 22.6.0.0
  • v 22.5.1.0

BUT in the v..22.5.0.0 there isn't any issue with the Uniformat Classification export.

@canpolatbaris
Copy link

Hi,
I have the same issue in Revit 2022 (IFC Exporter 22.6.0.0) and Revit 2023 (IFC Exporter 23.2.3.0).
I don't think this is a viewer issue.
image
image
image

Also, I exported one of the old projects, which had the right classification assignment before, and could not export classification in the right way.
I tried previous versions one by one, and version IFC.for.Revit.2023.1.0.0.msi exports classification for the same model properly.
image
image

@WawanSolihin
Copy link
Contributor

It has been fixed in the development version, but it did not make it for 22.6.
I can bring it forward to 2022 and if you do not mind unsigned build, it can be done soon.

@WawanSolihin
Copy link
Contributor

I bring forward the fix for the classification issue. There are pre-release (not signed) versions for Revit 2022 and Revit 2023 that you may want to test it out. In my testing they seem to work well.
For Revit 2022: https://github.com/Autodesk/revit-ifc/releases/tag/IFC_v22.6.1.0
For Revit 2023: https://github.com/Autodesk/revit-ifc/releases/tag/IFC_v23.2.4.0

@EtiennevdBa
Copy link
Author

I bring forward the fix for the classification issue. There are pre-release (not signed) versions for Revit 2022 and Revit 2023 that you may want to test it out. In my testing they seem to work well. For Revit 2022: https://github.com/Autodesk/revit-ifc/releases/tag/IFC_v22.6.1.0 For Revit 2023: https://github.com/Autodesk/revit-ifc/releases/tag/IFC_v23.2.4.0

@WawanSolihin Thanks for the pre-release. i've tested them to and its better, but the Name is missing

image
image

This is how it was before
image
image

@WawanSolihin
Copy link
Contributor

It works well in my test. I attached the sample file here. Assembly.0.2 (as identified by Solibri) shows the result as expected. (The Solibri version I use: 9.12)

image
Classification-test--2022.zip

@benjaminchvn
Copy link

I bring forward the fix for the classification issue. There are pre-release (not signed) versions for Revit 2022 and Revit 2023 that you may want to test it out. In my testing they seem to work well. For Revit 2022: https://github.com/Autodesk/revit-ifc/releases/tag/IFC_v22.6.1.0 For Revit 2023: https://github.com/Autodesk/revit-ifc/releases/tag/IFC_v23.2.4.0

Hi thank you for this pre-release. I have been testing out on both Uniformat (using Assembly code in Revit) and custom classification using a shared parameter, it seems to work fine.
Test2

@EtiennevdBa
Copy link
Author

It works well in my test. I attached the sample file here. Assembly.0.2 (as identified by Solibri) shows the result as expected. (The Solibri version I use: 9.12)

image Classification-test--2022.zip

@WawanSolihin, thanks for your reply, i'm using solibri 9.13.1
will check tonight with a different Solibri version. keep you posted.

@canpolatbaris
Copy link

It has been fixed in the development version, but it did not make it for 22.6. I can bring it forward to 2022 and if you do not mind unsigned build, it can be done soon.

thank you, I will start my tests today...

@louistrue
Copy link

Thats great, @GerbenB-KUBUS
Happy to help: [email protected]

@koenmeinema
Copy link

Perfect Gerben, i would love to help as well: [email protected]
Feedback i will post here if that is ok.

@EtiennevdBa
Copy link
Author

@AngelVelezSosa can you give us a update on this issues?

thanks in advance

@JoepvanMotman
Copy link

JoepvanMotman commented Nov 7, 2023

I'm also still having this issue. Assembly description is not getting exported to IFC. It has nothing to do with the viewer i guess since the descriptions are also not found when i search for them in notepad.

@koenmeinema
Copy link

@AngelVelezSosa could you please give us an update? Also the overwrite function in IFC Export > Modify > Property Sets > Classification Settings doesn't work as it should.

@AngelVelezSosa
Copy link
Contributor

@koenmeinema split out the last issue as this one is getting confusing due to multiple different problems, some already addressed. Is the question for an update on 2022?

@koenmeinema
Copy link

koenmeinema commented Jan 11, 2024

@AngelVelezSosa the issue Assembly Description not showing. In the past it was shown correctly in multiple IFC viewers as:

Uniformat Classification: [Assembly Code], [Assembly Description]

Now it's shown wrong as:

Uniformat: [Assembly code], Uniformat

@AngelVelezSosa
Copy link
Contributor

In all versions or 2022?

@koenmeinema
Copy link

@AngelVelezSosa I tried 2023 and 2024

@JoepvanMotman
Copy link

JoepvanMotman commented Jan 11, 2024

Hi @AngelVelezSosa there are several serious problems with Revit 2023 and 2024 when it goes to exporting any kind of classification. I have also send you some e-mails with models showing the issue. I think you did not yet find the time to answer those mails.

At this moment our company cannot work with Revit 2023 and 2024 since a lot of Clients require those classifications. The classiciation discription is nog getting exported and that has nothing to do with a viewer. When i search the IFC file in notepad i cannot find the descriptions.

I have tried everything. Just Revit 2023 / 2024 without or with any kind of IfcExporter from github. It is not working.

@AngelVelezSosa
Copy link
Contributor

Yes, sorry, we have been working against some deadlines. I will revisit the classification issue to see what we can do.

@dvrvb
Copy link

dvrvb commented Jan 13, 2024

Hi Angel,
I attached a simple model sample.
2024-01-13_R2022-R2023-R2024_classification.zip

I tested it for (the current versions of) R2022 2023 2024, for (the current versions of the IFC exporter) for IFC2x3CV2.0 and IFC4RV1.2.
It seems that for 2022/3/4 the description is missing (only) for IFC2x3.

image

Regards,
Dirk

@dvrvb
Copy link

dvrvb commented Jan 13, 2024

Next to this issue, there is also a Solibri issue, because Solibri is only showing the attribute "Name" and not the "Description"...

@koenmeinema
Copy link

Dear Angel,

Could you please give us an update? Still waiting for improvements...

With kind regards,

Koen

@AngelVelezSosa
Copy link
Contributor

We have plans to look at this in the near future.

@t-vasyi
Copy link
Contributor

t-vasyi commented Mar 20, 2024

The fix for the issues reported in this thread will be included in the next IFC Exporter releases.
Please, let me know if you still have any classification issues
Thanks

image
image

@koenmeinema
Copy link

koenmeinema commented Mar 21, 2024

Great, thanks! Do you have a download link so I can test?

@JoepvanMotman
Copy link

@t-vasyi thank you. When will the update be released? Also, did you test if this fixes the issue in all Revit versions? For as far as i know this issue is happening in RVT23 en RVT24.

@xpt5
Copy link

xpt5 commented Mar 21, 2024

@koenmeinema the latest exporter version for 2022 is here https://github.com/Autodesk/revit-ifc/releases/tag/IFC_v22.7.0

@AngelVelezSosa
Copy link
Contributor

I don't know if this fix made the 2022 cut-off, @o-babii ?

@AngelVelezSosa
Copy link
Contributor

To the other questions, we don't publish release dates, but in general we hope to include in a future release for all supported versions. We always do have to balance future work and back-submissions, and not everything can be back-submitted, but these changes I believe are eligible.

@o-babii
Copy link
Collaborator

o-babii commented Mar 21, 2024

Unfortunately, version 22.7 does not fix this bug, the exported classification looks the same as for the previous version 22.6.2

@t-vasyi
Copy link
Contributor

t-vasyi commented Mar 22, 2024

@t-vasyi thank you. When will the update be released? Also, did you test if this fixes the issue in all Revit versions? For as far as i know this issue is happening in RVT23 en RVT24.

yes, fix works for all the versions

@t-vasyi
Copy link
Contributor

t-vasyi commented Mar 22, 2024

The fix wasn't included to 22.7

@aksel-a
Copy link

aksel-a commented May 2, 2024

Hi there! I'm running R24 with the latest release of IFC exporter and the classification problem persists. What I can add is that I lost the ability to map Assembly Code and Assembly Description to a custom PSet, as I was doing before.

Any chances there is already a solution? I wasn't aware of this issue, would it be good to report it in the log of the IFC-Export Releases, isn't?

@xpt5
Copy link

xpt5 commented May 3, 2024

Hi @aksel-a, you are mentioning two Revit type parameters. Did you adapt the custom Pset txt file to consider IfcElementType?
I had the same issue, check this

@JoepvanMotman
Copy link

@AngelVelezSosa @t-vasyi

I was wondering when this issue is finally getting fixt? Still the Assembly Description is not getting exported when using RVT 23.

@t-vasyi
Copy link
Contributor

t-vasyi commented Aug 9, 2024

The fix for the issues reported in this thread will be included in the next IFC Exporter releases. Please, let me know if you still have any classification issues Thanks

image image

The fixed Jira ticket is REVIT-219651

It is included in:
Release 25.2 for Revit 2025
Release 24.2.20 for Revit 2024
Release 23.X for Revit 2023 (upcoming)

Not included in Release 22.7 for Revit 2022

If you are still facing issues using one of these Releases, please share a simple model + exported IFC file.
I think it is also a good idea to create a new thread in this case.

Regards,
Ihor Vasyliev

@koenmeinema
Copy link

Hi @t-vasyi,

I tried it with Revit 24.2.20 and it finally works like it should! Thanks.

Kind regards,
Koen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023 version export Issue with exporting process or results in progress Issue currently being addressed by developer parameters-properties Error in resulting Revit parameter or IFC properties/property sets problem Something isn't working Revit
Projects
None yet
Development

No branches or pull requests