Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setUndoManager prevents access to existing history #136

Open
johngodley opened this issue May 5, 2022 · 1 comment
Open

setUndoManager prevents access to existing history #136

johngodley opened this issue May 5, 2022 · 1 comment
Labels
bug Something isn't working [Feature] Collaboration Real-time collaborative editing

Comments

@johngodley
Copy link
Member

If you are editing some content and have built up an undo history, and then setUndoManager is called, it prevents access to the existing history.

This may occur, for example, on P2 where you can be creating a new post (collab is disabled) and a draft is saved. At this point, collab mode is enabled (the conditions for it are now true) and existing undo history is lost. Given the right set of circumstances this could result in data being lost.

@johngodley johngodley added bug Something isn't working [Feature] Collaboration Real-time collaborative editing labels May 5, 2022
@johngodley
Copy link
Member Author

You can also get the same effect if you start typing in an editor before setUndoManager is called. In my testing there's sometimes a 10 second gap from when the editor is editable and the undo manager kicks in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [Feature] Collaboration Real-time collaborative editing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant