Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collab undo history and lists #137

Open
johngodley opened this issue May 5, 2022 · 3 comments
Open

Collab undo history and lists #137

johngodley opened this issue May 5, 2022 · 3 comments
Labels
bug Something isn't working [Feature] Collaboration Real-time collaborative editing

Comments

@johngodley
Copy link
Member

There seems to be a problem with undo history and lists. To reproduce:

  • With collab mode enabled (you don't need a peer), create a list
    image
  • On the last line press enter to escape out of the list
    image
  • Type some characters slowly so they each get an undo history event
    image
  • Undo each character and undo back into the list. When you transition from the paragraph to the list the selection point disappears and you have lost your redo history
    image

I'll note that sometimes, depending on a situation I don't understand, I am able to briefly get undo or redo to work. However, it then goes into another situation I don't understand and stops working.

@johngodley johngodley added bug Something isn't working [Feature] Collaboration Real-time collaborative editing labels May 5, 2022
@johngodley
Copy link
Member Author

Noting that I now can't get this to happen. Investigating!

@johngodley
Copy link
Member Author

I'm not able to reproduce the loss of undo history anymore. However, with collab enabled when you undo from the paragraph into the empty list item the focus jumps out of the editor. Without collab this doesn't seem to happen. I've seen a similar problem where if you undo beyond the start of the history the focus would jump to another element. I wasn't able to find the underlying problem there, and solved it with some CSS that hid the element it was focussing on.

@johngodley
Copy link
Member Author

The focus one I've narrowed down in #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [Feature] Collaboration Real-time collaborative editing
Projects
None yet
Development

No branches or pull requests

1 participant