Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: convert jetpack_blocks_disabled option to a module #39441

Closed
kraftbj opened this issue Sep 18, 2024 · 0 comments · Fixed by #39449
Closed

Performance: convert jetpack_blocks_disabled option to a module #39441

kraftbj opened this issue Sep 18, 2024 · 0 comments · Fixed by #39449
Assignees
@kraftbj
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] Performance [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone
jetpack/13.9

Comments

@kraftbj
Copy link
Contributor

kraftbj commented Sep 18, 2024 •
edited
Loading

Impacted plugin

Jetpack

What

Transform jetpack_blocks_disabled to a module

How

The jetpack_blocks_disabled option exists to provide a way for a site admin to enable/disable Jetpack blocks via the UI, which is basically the same concept as Jetpack modules.

jetpack_blocks_disabled is only set when the toggle has been used, which means it is not cached and a source of regular db calls. Transforming it into a proper module would allow it to piggyback with the modules option call/cache.

Follow-up of #39422
@kraftbj kraftbj added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Focus] Performance [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Sep 18, 2024
@kraftbj kraftbj mentioned this issue Sep 19, 2024
Merged
3 tasks
@kraftbj kraftbj added this to the jetpack/13.9 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kraftbj kraftbj

Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] Performance [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
jetpack/13.9
Development

Successfully merging a pull request may close this issue.

Blocks: convert to module Automattic/jetpack
1 participant
@kraftbj