Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass $post_id to msm_sitemap_skip_post #183

Open
BrookeDot opened this issue Aug 22, 2024 · 0 comments · May be fixed by #184
Open

Pass $post_id to msm_sitemap_skip_post #183

BrookeDot opened this issue Aug 22, 2024 · 0 comments · May be fixed by #184

Comments

@BrookeDot
Copy link

When the msm_sitemap_skip_post filter was added the decision was made not to pass the post_id. The logic at the time was:

This filter is called in the loop, so post data is not passed through the filter.

The current best practice is to pass the Post ID, which will make programmatically skipping posts much easier.
BrookeDot added a commit that referenced this issue Aug 22, 2024
@BrookeDot
Add Post ID to msm_sitmap_skip_posts
54e3efc 
Adds the post ID to msm_sitmap_skip_posts

This is a backwards incompatible change, as it adds a second argument to the filter

Fixes #183
@BrookeDot BrookeDot linked a pull request Aug 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Post ID to msm_sitmap_skip_posts Automattic/msm-sitemap
1 participant
@BrookeDot