Add Post ID to msm_sitmap_skip_posts #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the post ID to msm_sitmap_skip_posts This is a backwards incompatible change, as it adds a second argument to the filter Fixes #183
|
This will probably need to be tested with someone using the filter currently, as I can't find any examples! |
|
Makes sense @pkevan the other thought I had was to support both (adding a new filter for the addition of Thoughts? |
|
Probably preferable just to have one filter - in theory it shouldn't break by adding a parameter (as 1 parameter is the default for all filters), but depends on how legacy application have been calling it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
$post_idto themsm_sitmap_skip_postsfilter. Doing so allows for posts to be excluded by using the filter directly.Note: this is a backward incompatible change, as it adds a second argument to the filter
Fixes #183