Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it more obvious to the developer when the server needs to be restarted #499

Open
danielbachhuber opened this issue Sep 2, 2024 · 1 comment

Comments

@danielbachhuber
Copy link
Contributor

While working on #497, I was confused at times on why my changes weren't being applied. As it turns out, any changes to the Node server files (e.g. https://github.com/Automattic/studio/pull/497/files#diff-eb193b2da1aa77c2b5b32588db5da8fbc06580ee0de1e0cec4f30893bec6f604R300-R324) require a server restart.

We include some mention of this, but it's not obvious unless you already know where to look.

We should make it more obvious to the developer when they're making changes to a file that require a server restart (or we should just restart the server automatically).

@wojtekn
Copy link
Contributor

wojtekn commented Sep 10, 2024

For reference, it currently states:

The app automatically launches with the Chromium developer tools opened by default. Changes to the "renderer" process code will automatically reload the app, changes to the main process code require a manual server restart or typing rs into the same terminal where the server was started.

It would be beneficial to make it more precise indeed, e.g., by providing example file paths or functions/classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants