Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't access the application menu when using an RTL language on Windows #541

Open
fluiddot opened this issue Sep 16, 2024 · 2 comments
Open
Assignees
Labels
[Platform] Windows The issue is specific to the Windows platform. [Pri] Low Studio App Triaged [Type] Bug Something isn't working

Comments

@fluiddot
Copy link
Contributor

fluiddot commented Sep 16, 2024

Quick summary

The button that opens the application menu on Windows is not visible when using an RTL language.

Steps to reproduce

  1. Open the app with a non-RTL language.
  2. Observe that in the top-left corner, there's a burger menu that opens the application menu.
  3. Open the settings window.
  4. Change the language to an RTL language (e.g. Hebrew).
  5. Observe that the button is no longer visible.

What you expected to happen

The application menu should be accessible when using any language.

What actually happened

The application menu is not accessible when using an RTL language.

Impact

Some (< 50%)

Available workarounds?

No but the app is still usable

Platform

Windows

Logs or notes

367849609-713448b2-df41-4c13-a678-2aae1bbab083
@fluiddot fluiddot added [Type] Bug Something isn't working Needs triage Ticket needs to be triaged [Platform] Windows The issue is specific to the Windows platform. labels Sep 16, 2024
@Robertght
Copy link

📌 REPRODUCTION RESULTS

  • Tested Studio(1.1.3) on Windows 11

📌 FINDINGS/SCREENSHOTS/VIDEO

  • I also found these overlapping items:
    image

📌 ACTIONS

  • Triaged

@Robertght Robertght added Triaged and removed Needs triage Ticket needs to be triaged labels Oct 1, 2024
@p-jackson p-jackson self-assigned this Oct 11, 2024
@p-jackson
Copy link
Member

Setting the app language to Arabic flips the order of the topbar controls. However it doesn't move the location of the standard Windows controls. To do that the language needs to be changed on an operating system level.

If I hardcode the window frame to show in Arabic (as well as our internal app setting) then things look more correct. There's still some padding that needs to be adjusted, but it's a lot closer.

Image

Ideally we'd be able to detect and handle both cases:

  • If studio settings are set to RTL and the OS is set to RTL
  • If studio settings are set to RTL but the OS is set to LTR (as in the original bug report)

The reason I think both are important is because it's so easy to click through the languages without resting your system, and you wouldn't expect it to look borked.

It looks like it's possible to distinguish in the UI when the browser frame itself is set to a RTL language using: new Intl.Locale(navigator.language).textInfo.direction. So I think we can make it.

Maybe as a follow up task, we could have Studio offer to restart itself whenever the user switches languages, so that the studio setting and browser frame setting are always aligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Platform] Windows The issue is specific to the Windows platform. [Pri] Low Studio App Triaged [Type] Bug Something isn't working
Projects
Development

No branches or pull requests

4 participants