Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP REST API Transport Layer #116

Open
emrikol opened this issue Aug 11, 2016 · 4 comments
Open

WP REST API Transport Layer #116

emrikol opened this issue Aug 11, 2016 · 4 comments

Comments

@emrikol
Copy link
Contributor

emrikol commented Aug 11, 2016

The primary transport layer out of the box should be WP REST API.

This would also include implementing any necessary authentication support for a "push" transport.

@emrikol emrikol added this to the v2.1 milestone Aug 11, 2016
@timdunhamusat
Copy link

@emrikol Hi. I'm Tim Dunham from USA Today. I work with Ephraim Gregor. He suggested I work on this issue. I see that a REST API transport layer exists for the old version of the REST API. Are we going to appropriate that file and rewrite it to use the "new" REST API, or is there some reason to keep the existing one and create a different file? Sorry to ask such a simple question, but I'd rather not start off by messing things up.

@emrikol
Copy link
Contributor Author

emrikol commented Aug 29, 2016

Hi @timdunhamusat!

The "old" REST API functionality was specifically built for the WordPress.com REST API. Our plan moving forward is to use the core WordPress (.org) REST API.

I've unfortunately done a lot of looking to see how much of the current code could be rewritten to use the core REST API, but if it could be reused it would be a great time saver :)

Hopefully that answered your question. If not, or if you have others, please let me know.

Thanks!

@MattGeri
Copy link

MattGeri commented Jul 3, 2017

Hi @emrikol and @philipjohn,

I'm about to start working on this. I have two initial questions:

  1. Should the REST API implementation support PUSH and PULL transport, or just PUSH?
  2. What types of authentication should this support. Currently, from what I understand, only cookie based authentication is supported in the .org REST API (which wouldn't work for us). Are we going to rely on the user to have an OAuth plugin enabled or one of the other authentication methods/plugins? I'm of course disregarding basic auth which is not encourage for production.

Thanks!
Matt

@philipjohn
Copy link
Contributor

  1. For now, let's focus on PUSH. We already have the REST PUSH client for WordPress.com so we can build upon that.

We also need to make sure that the existing REST PUSH client works with WordPress.com first.

  1. For the WP.com API client, an app needs to be created and authentication is via tokens provided as part of that.

For any WP REST API endpoints let's stick to OAuth for now.

Also cc @joshbetz for any thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants