Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Pendant: Links outside post content aren't underlined. #7505

Closed
scruffian opened this issue Nov 20, 2023 · 2 comments · Fixed by #8257
Closed

[Bug]: Pendant: Links outside post content aren't underlined. #7505

scruffian opened this issue Nov 20, 2023 · 2 comments · Fixed by #8257
Assignees
Labels
Accessibility [Feature Group] Appearance & Themes Features related to the appearance of sites. Groundskeeping Worked on by Dotcom Groundskeeping [Pri] Normal [Theme] Pendant Themes Triaged [Type] Bug Something isn't working

Comments

@scruffian
Copy link
Member

Quick summary

In Pendant (and probably other themes), links outside the Post Content have underline turned off:

"textDecoration": "none"

If I edit my home page to add a link to it, there is no way to make that link be underlined, without using a keyboard shortcut (see WordPress/gutenberg#56321).

We should reconsider this approach as it makes it difficult to for websites to be accessible.

cc @beafialho

Steps to reproduce

  1. Switch to Pendant
  2. Edit the Blog Home template
  3. Add a new paragraph with a link
  4. Notice that the link is not underlined

What you expected to happen

There should be a way to underline this link.

What actually happened

It's impossible unless I use a keyboard shortcut.

Browser

No response

Context

No response

Platform (Simple, Atomic, or both?)

No response

Other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

None

Workaround details

No response

@liviopv
Copy link

liviopv commented Dec 27, 2023

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

CleanShot.2023-12-27.at.10.19.22.mp4

📌 ACTIONS

  • Triaged

📌 Message to Author
@scruffian it's possible to make the link underlined by selecting it from the block tool bar as shown towards the end of the video above.

@scruffian
Copy link
Member Author

Thanks, that is a workaround, but I don't think we should expect users to have to do this for every link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility [Feature Group] Appearance & Themes Features related to the appearance of sites. Groundskeeping Worked on by Dotcom Groundskeeping [Pri] Normal [Theme] Pendant Themes Triaged [Type] Bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants