-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Shore: add theme #7917
The Shore: add theme #7917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a general accessibility review on the templates. Mostly just adding alt text to images and some html tag changes.
The logo and nav menu can be difficult to see on the background at some sizes. Would a gradient at the top of the page help?The mobile menus look different on the homepage and single pages:
Homepage
<div class="wp-block-column" style="flex-basis:66.66%"><!-- wp:columns --> | ||
<div class="wp-block-columns"><!-- wp:column --> | ||
<div class="wp-block-column"><!-- wp:paragraph {"style":{"typography":{"fontSize":"0.8rem","textTransform":"uppercase","letterSpacing":"0.1em","fontStyle":"normal","fontWeight":"500"},"elements":{"link":{"color":{"text":"var:preset|color|primary"}}}},"textColor":"primary","fontFamily":"commissioner"} --> | ||
<p class="has-primary-color has-text-color has-link-color has-commissioner-font-family" style="font-size:0.8rem;font-style:normal;font-weight:500;letter-spacing:0.1em;text-transform:uppercase">Address</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be an H2 or H3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, since the footer is present on all pages and we can't assure that every page is going to have the same heading structure
|
||
<!-- wp:column --> | ||
<div class="wp-block-column"><!-- wp:paragraph {"style":{"typography":{"textTransform":"uppercase","letterSpacing":"0.1em","fontStyle":"normal","fontWeight":"500"},"elements":{"link":{"color":{"text":"var:preset|color|primary"}}}},"textColor":"primary","fontSize":"x-small","fontFamily":"commissioner"} --> | ||
<p class="has-primary-color has-text-color has-link-color has-commissioner-font-family has-x-small-font-size" style="font-style:normal;font-weight:500;letter-spacing:0.1em;text-transform:uppercase">Contact</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be an H2 or H3
Preview changesI've detected changes to the following themes in this PR: The Shore. You can preview these changes by following the links below: I will update this comment with the latest preview links as you push more changes to this PR. |
I made all the fixes that I could. The things that are still standing are:
I don't think these should be blockers personally |
I updated the header to use a gradient instead of a solid color. I say lets bring this in. |
The Shore is a sleek and elegant WordPress theme designed specifically for hotels and resorts. It offers three distinct color variations, allowing you to customize the look and feel to match your brand perfectly. With its clean and modern design, The Shore provides a seamless and user-friendly experience for visitors. Its layout is thoughtfully crafted to showcase your property’s features, amenities, and services, making it easy to attract and engage potential guests. Ideal for creating a professional online presence, The Shore combines aesthetics with functionality, ensuring your hotel or resort stands out in the competitive hospitality industry.