Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Shore: add theme #7917

Conversation

beafialho
Copy link
Collaborator

@beafialho beafialho commented Jul 3, 2024

The Shore is a sleek and elegant WordPress theme designed specifically for hotels and resorts. It offers three distinct color variations, allowing you to customize the look and feel to match your brand perfectly. With its clean and modern design, The Shore provides a seamless and user-friendly experience for visitors. Its layout is thoughtfully crafted to showcase your property’s features, amenities, and services, making it easy to attract and engage potential guests. Ideal for creating a professional online presence, The Shore combines aesthetics with functionality, ensuring your hotel or resort stands out in the competitive hospitality industry.

screenshot

@beafialho beafialho changed the title Update theme the-shore The Shore: Add theme Jul 4, 2024
@beafialho beafialho changed the title The Shore: Add theme The Shore: add theme Jul 4, 2024
@beafialho beafialho mentioned this pull request Jul 4, 2024
@jasmussen jasmussen mentioned this pull request Jul 15, 2024
Copy link

@jeryj jeryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a general accessibility review on the templates. Mostly just adding alt text to images and some html tag changes.

homepage header on mobile with low color contrast between logo and background The logo and nav menu can be difficult to see on the background at some sizes. Would a gradient at the top of the page help?

The mobile menus look different on the homepage and single pages:
Homepage
menu with small text right aligned

Single
Large left aligned text

the-shore/patterns/header-homepage.php Outdated Show resolved Hide resolved
the-shore/patterns/header-homepage.php Outdated Show resolved Hide resolved
the-shore/patterns/home.php Outdated Show resolved Hide resolved
the-shore/patterns/home.php Outdated Show resolved Hide resolved
the-shore/patterns/home.php Show resolved Hide resolved
the-shore/patterns/home.php Outdated Show resolved Hide resolved
the-shore/patterns/home.php Outdated Show resolved Hide resolved
the-shore/patterns/home.php Outdated Show resolved Hide resolved
<div class="wp-block-column" style="flex-basis:66.66%"><!-- wp:columns -->
<div class="wp-block-columns"><!-- wp:column -->
<div class="wp-block-column"><!-- wp:paragraph {"style":{"typography":{"fontSize":"0.8rem","textTransform":"uppercase","letterSpacing":"0.1em","fontStyle":"normal","fontWeight":"500"},"elements":{"link":{"color":{"text":"var:preset|color|primary"}}}},"textColor":"primary","fontFamily":"commissioner"} -->
<p class="has-primary-color has-text-color has-link-color has-commissioner-font-family" style="font-size:0.8rem;font-style:normal;font-weight:500;letter-spacing:0.1em;text-transform:uppercase">Address</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be an H2 or H3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, since the footer is present on all pages and we can't assure that every page is going to have the same heading structure


<!-- wp:column -->
<div class="wp-block-column"><!-- wp:paragraph {"style":{"typography":{"textTransform":"uppercase","letterSpacing":"0.1em","fontStyle":"normal","fontWeight":"500"},"elements":{"link":{"color":{"text":"var:preset|color|primary"}}}},"textColor":"primary","fontSize":"x-small","fontFamily":"commissioner"} -->
<p class="has-primary-color has-text-color has-link-color has-commissioner-font-family has-x-small-font-size" style="font-style:normal;font-weight:500;letter-spacing:0.1em;text-transform:uppercase">Contact</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be an H2 or H3

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Preview changes

I've detected changes to the following themes in this PR: The Shore.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@MaggieCabrera
Copy link
Contributor

I made all the fixes that I could. The things that are still standing are:

  • The contrast problem between the header text and the cover image. Since this image is meant for the user to replace, I'd suggest to change it to one that is darker, or we can go for the gradient solution.
  • The navigation differences on mobile can't be addresses without changing how it looks on desktop too if we want to keep the bigger version. This is a shortcoming of the block, where the font size is the same for desktop and the overlay

I don't think these should be blockers personally

@scruffian
Copy link
Member

I updated the header to use a gradient instead of a solid color. I say lets bring this in.

@scruffian scruffian merged commit 45c515f into Automattic:trunk Sep 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants