Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BNPL PMME and icon placement in shortcode checkout #9817

Closed
FangedParakeet opened this issue Nov 27, 2024 · 10 comments · Fixed by #9993
Closed

Improve BNPL PMME and icon placement in shortcode checkout #9817

FangedParakeet opened this issue Nov 27, 2024 · 10 comments · Fixed by #9993
Assignees
Labels
focus: checkout payments type: enhancement The issue is a request for an enhancement.

Comments

@FangedParakeet
Copy link
Contributor

Description

This issue is a follow-up to #9488, dividing up the work comprising this issue into individual bite-sized chunks.

This issue is to amend the placement and positioning of the BNPL PMME and payment method icon.

Acceptance criteria

Current bad state
Current bad state

Desired good state
Desired good state

In order to resolve this issue, we would like to achieve the following:

  • PMME is left-aligned horizontally with the label text.
  • Payment method icon is centre-aligned vertically with both label text and PMME.

Limitations

Note that we should attempt to make this placement as consistent across themes as possible, but be aware that different themes control the positioning of these radio label elements very differently. If there are limitations to what we are able to achieve, please explain the limitations on this issue with the expectation that this is part of a series of incremental changes and we should try to accomplish the best experience possible within the constraint of what is feasible.

Additional context

#9488

@FangedParakeet FangedParakeet added focus: checkout payments type: enhancement The issue is a request for an enhancement. labels Nov 27, 2024
@FangedParakeet FangedParakeet added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Nov 27, 2024
@FangedParakeet FangedParakeet changed the title Improve BNPL PMME and icon placement Improve BNPL PMME and icon placement in shortcode checkout Nov 27, 2024
@FangedParakeet
Copy link
Contributor Author

Moving this to the backlog until we have a consistent solution to add DOM elements to label in #9819.

@gpressutto5
Copy link
Contributor

@pierorocca @FangedParakeet Double checking we want to to vertically center the payment method logo differently than in the Blocks Checkout.

Blocks checkout currently:

Image

@gpressutto5
Copy link
Contributor

Regarding the PMME alignment, it looks like a problem with the theme. I tested with some other themes and all of them have the PMME correctly aligned.
The text is misaligned in the Storefront theme because of the way it renders the icon that replaces the radio button. This icon is in an inline ::before.

Twenty Twenty-Five
Image

Blockbase
Image

aThemeArt’s Shopper
Image

@pierorocca
Copy link
Contributor

@pierorocca @FangedParakeet Double checking we want to to vertically center the payment method logo differently than in the Blocks Checkout.

Centered on all checkouts. The design called for vertical centering of the logo so the Blocks implementation, if not a theme issue, is incorrect.

@pierorocca
Copy link
Contributor

pierorocca commented Dec 16, 2024

I believe there's an open issue as well to reduced the font size of the second line of text which should help with the visual balance as well as amount of PMME text that can be shown before it wraps on mobile.

Having said that, what happens on shortcode in a 2 or 3 column design where the container is super narrow and the text is on 3 row and the icon is centered? How does that look?

@gpressutto5
Copy link
Contributor

@pierorocca These themes I used as example are not 3 column, the only difference with them is that the PMME is correctly aligned with the label.

Image

Now, I noticed Brett is working on a 3 column design in #9775 and I think that PR alone might close this issue. This is how it would look like in a extremely narrow container. I think it looks good, considering this is so narrow any gateway would look broken.

Image

@gpressutto5 gpressutto5 removed the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Dec 16, 2024
@pierorocca
Copy link
Contributor

Thank you. I've been using 375px as the floor recently as that covers iPhone 6 and above. Anything below that I'm not concerned about potential visual issues that don't impact functionality.

@pierorocca
Copy link
Contributor

Also the 2nd row of text is soon getting smaller so it won't be as bad as shown above.

@gpressutto5
Copy link
Contributor

I've been trying to resolve the conflicts or reapply the changes from that branch until I noticed it only works with the rich payment method label, which was removed in #9800. I'm trying to find a new way to do this.

@FangedParakeet
Copy link
Contributor Author

Please add your planning poker estimate with Zenhub @gpressutto5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout payments type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants