-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve BNPL PMME and icon placement in shortcode checkout #9817
Comments
Moving this to the backlog until we have a consistent solution to add DOM elements to label in #9819. |
@pierorocca @FangedParakeet Double checking we want to to vertically center the payment method logo differently than in the Blocks Checkout. Blocks checkout currently: |
Regarding the PMME alignment, it looks like a problem with the theme. I tested with some other themes and all of them have the PMME correctly aligned. |
Centered on all checkouts. The design called for vertical centering of the logo so the Blocks implementation, if not a theme issue, is incorrect. |
I believe there's an open issue as well to reduced the font size of the second line of text which should help with the visual balance as well as amount of PMME text that can be shown before it wraps on mobile. Having said that, what happens on shortcode in a 2 or 3 column design where the container is super narrow and the text is on 3 row and the icon is centered? How does that look? |
@pierorocca These themes I used as example are not 3 column, the only difference with them is that the PMME is correctly aligned with the label. Now, I noticed Brett is working on a 3 column design in #9775 and I think that PR alone might close this issue. This is how it would look like in a extremely narrow container. I think it looks good, considering this is so narrow any gateway would look broken. |
Thank you. I've been using 375px as the floor recently as that covers iPhone 6 and above. Anything below that I'm not concerned about potential visual issues that don't impact functionality. |
Also the 2nd row of text is soon getting smaller so it won't be as bad as shown above. |
I've been trying to resolve the conflicts or reapply the changes from that branch until I noticed it only works with the rich payment method label, which was removed in #9800. I'm trying to find a new way to do this. |
Please add your planning poker estimate with Zenhub @gpressutto5 |
Description
This issue is a follow-up to #9488, dividing up the work comprising this issue into individual bite-sized chunks.
This issue is to amend the placement and positioning of the BNPL PMME and payment method icon.
Acceptance criteria
Current bad state
Desired good state
In order to resolve this issue, we would like to achieve the following:
Limitations
Note that we should attempt to make this placement as consistent across themes as possible, but be aware that different themes control the positioning of these radio label elements very differently. If there are limitations to what we are able to achieve, please explain the limitations on this issue with the expectation that this is part of a series of incremental changes and we should try to accomplish the best experience possible within the constraint of what is feasible.
Additional context
#9488
The text was updated successfully, but these errors were encountered: