-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Improvement: Status controls could have a way to have icons instead of the default letters #1157
Comments
Please assign this to me |
Hello @pravintargaryen, Our core maintainer team still needs to review this issue. We are still determining if or how we want to include it in the taipy library. Please give us some time to review the issue before engaging it. This should not be long. Meanwhile, I invite you to look at the issues with the labels "good first issue" or "Help wanted". These tickets have been reviewed, approved and are opened for a contribution. thank you. |
Hello @pravintargaryen, The issue has been reviewed. Thank you for volunteering. Go ahead, give it a try. |
Thank you @jrobinAV and @pravintargaryen The real difficulty is going to be to keep the control's property API backward compatible. |
Hello @pravintargaryen, Any news on the issue? Cheers, |
Hi @jrobinAV, Apologies for being behind schedule Working on new icons from Material UI for the frontend status component. Have to test it though. \taipy\frontend\taipy-gui\src\components\Taipy\Status.tsx |
No pb. Take the time you need, of course. |
Are the new icons "in line" with the icons we already use ? |
This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines. |
Approaching PR |
PR #1413 |
Thank you @pravintargaryen. The maintainers team is reviewing your PR. |
This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines. |
Made a glitch from my end #1413. Will resend the PR. |
Sent a pull request with updated branch details #1580 |
This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines. |
Please assign this issue to me @jrobinAV. |
@Vaibhav91one Sure. Thank you for your help. Let me assign it to you. To avoid making the same errors, please consider looking at previous closed PRs. Thanks |
Thanks @jrobinAV, Will give a look at previous closed PR's. |
Hi @jrobinAV, I had a few queries before moving forward. Is there a way to check the changes that were made locally. And also in contributing docs, it says to create a local env which means to create a virutal environment right? |
@Vaibhav91one Yes, absolutely. Creating a dedicated environment for testing your changes will definitely help. @namnguyen20999 @FabienLelaquais @dinhlongviolin1 @FredLL-Avaiga are front-end developers. They are used to test their devs all the time. They should be able to help you with that. |
This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines. |
Will be submitting a PR soon. |
Hi @jrobinAV @namnguyen20999 @FabienLelaquais @dinhlongviolin1 @FredLL-Avaiga . PFA, the variants of the icon and Pleae provide feedback. |
…bug/Avaiga#1157-feat-improv-status-control
…bug/Avaiga#1157-feat-improv-status-control
…github.com/Vaibhav91one/taipy into bug/Avaiga#1157-feat-improv-status-control
This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines. |
Description
For the Status GUI control, instead of showing E, S, I and W, it would be nice to have a way to put icons in it instead.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: