Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Improvement: Status controls could have a way to have icons instead of the default letters #1157

Open
4 tasks
gbritoda opened this issue Apr 11, 2024 · 26 comments · May be fixed by #2177
Open
4 tasks
Assignees
Labels
🖰 GUI Related to GUI hacktoberfest - 200💎💎 Issues rewarded by 200 points hacktoberfest hacktoberfest issues 🆘 Help wanted Open to participation from the community 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed

Comments

@gbritoda
Copy link

Description
For the Status GUI control, instead of showing E, S, I and W, it would be nice to have a way to put icons in it instead.

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%
  • Propagate any change on the demos and run all of them to ensure there is no breaking change
  • Ensure any change is well documented
  • Status control from TaiPy gui can have Icons instead of the default letters
@gbritoda gbritoda added the 📈 Improvement Improvement of a feature. label Apr 11, 2024
@jrobinAV jrobinAV added the 🖰 GUI Related to GUI label Apr 19, 2024
@pravintargaryen
Copy link

Please assign this to me

@jrobinAV
Copy link
Member

jrobinAV commented Apr 22, 2024

Hello @pravintargaryen,

Our core maintainer team still needs to review this issue. We are still determining if or how we want to include it in the taipy library. Please give us some time to review the issue before engaging it. This should not be long.

Meanwhile, I invite you to look at the issues with the labels "good first issue" or "Help wanted". These tickets have been reviewed, approved and are opened for a contribution.

thank you.

@jrobinAV jrobinAV added 🆘 Help wanted Open to participation from the community 🟨 Priority: Medium Not blocking but should be addressed labels May 3, 2024
@jrobinAV
Copy link
Member

jrobinAV commented May 3, 2024

Hello @pravintargaryen,

The issue has been reviewed. Thank you for volunteering. Go ahead, give it a try.
This is not so easy, so make sure you get in touch with the appropriate maintainers:
@FredLL-Avaiga @FabienLelaquais @dinhlongviolin1 @namnguyen20999

@FabienLelaquais
Copy link
Member

Thank you @jrobinAV and @pravintargaryen

The real difficulty is going to be to keep the control's property API backward compatible.
We certainly can help designing this.

@jrobinAV
Copy link
Member

Hello @pravintargaryen,

Any news on the issue?

Cheers,

@pravintargaryen
Copy link

Hi @jrobinAV,

Apologies for being behind schedule

Working on new icons from Material UI for the frontend status component. Have to test it though.

\taipy\frontend\taipy-gui\src\components\Taipy\Status.tsx
\taipy\frontend\taipy-gui\src\components\Taipy\StatusList.tsx

1

@jrobinAV
Copy link
Member

No pb. Take the time you need, of course.

@FredLL-Avaiga
Copy link
Member

Hi @jrobinAV,

Apologies for being behind schedule

Working on new icons from Material UI for the frontend status component. Have to test it though.

\taipy\frontend\taipy-gui\src\components\Taipy\Status.tsx \taipy\frontend\taipy-gui\src\components\Taipy\StatusList.tsx

1

Are the new icons "in line" with the icons we already use ?
I thought you'd design a way to provide external icons ie allows the developer to add icons without changing the taipy-gui bundle.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Jun 5, 2024
@pravintargaryen
Copy link

Approaching PR

@pravintargaryen
Copy link

PR #1413

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Jul 9, 2024
@Avaiga Avaiga deleted a comment from github-actions bot Jul 10, 2024
@jrobinAV jrobinAV removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Jul 10, 2024
@jrobinAV
Copy link
Member

Thank you @pravintargaryen. The maintainers team is reviewing your PR.

Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Jul 24, 2024
@pravintargaryen
Copy link

Made a glitch from my end #1413. Will resend the PR.

@pravintargaryen
Copy link

Sent a pull request with updated branch details #1580

@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Jul 25, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@Vaibhav91one
Copy link

Please assign this issue to me @jrobinAV.

@jrobinAV
Copy link
Member

jrobinAV commented Oct 1, 2024

@Vaibhav91one Sure.

Thank you for your help. Let me assign it to you.

To avoid making the same errors, please consider looking at previous closed PRs.

Thanks

@Vaibhav91one
Copy link

Thanks @jrobinAV, Will give a look at previous closed PR's.

@Vaibhav91one
Copy link

Hi @jrobinAV, I had a few queries before moving forward. Is there a way to check the changes that were made locally. And also in contributing docs, it says to create a local env which means to create a virutal environment right?

@jrobinAV
Copy link
Member

jrobinAV commented Oct 2, 2024

@Vaibhav91one Yes, absolutely. Creating a dedicated environment for testing your changes will definitely help.

@namnguyen20999 @FabienLelaquais @dinhlongviolin1 @FredLL-Avaiga are front-end developers. They are used to test their devs all the time. They should be able to help you with that.

Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Oct 17, 2024
@Vaibhav91one
Copy link

Will be submitting a PR soon.

@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Oct 27, 2024
@Vaibhav91one
Copy link

Vaibhav91one commented Oct 27, 2024

Hi @jrobinAV @namnguyen20999 @FabienLelaquais @dinhlongviolin1 @FredLL-Avaiga . PFA, the variants of the icon and Pleae provide feedback.

  1. Variant 1:
    image
  2. Variant 2:
    image

Vaibhav91one added a commit to Vaibhav91one/taipy that referenced this issue Oct 28, 2024
Vaibhav91one added a commit to Vaibhav91one/taipy that referenced this issue Nov 8, 2024
Vaibhav91one added a commit to Vaibhav91one/taipy that referenced this issue Nov 8, 2024
Vaibhav91one added a commit to Vaibhav91one/taipy that referenced this issue Nov 8, 2024
Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 11, 2024
@FredLL-Avaiga FredLL-Avaiga removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI hacktoberfest - 200💎💎 Issues rewarded by 200 points hacktoberfest hacktoberfest issues 🆘 Help wanted Open to participation from the community 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed
Projects
None yet
6 participants